Use native aes-128-gcm support in Node 4 rather than npm-node-aes-gcm package #7548
Conversation
| decipher.setAuthTag(new Buffer(ciphertext.authTag, "base64")); | ||
| var chunks = [decipher.update( | ||
| new Buffer(ciphertext.ciphertext, "base64"))]; | ||
| chunks.push(decipher.final()); |
There was a problem hiding this comment.
Not clear to me at which step crypto throws or otherwise indicates decryption or authentication errors but it looks like this change does affect how errors are detected? Or do you need to add an error handler?
There was a problem hiding this comment.
Oh never mind. I remembered that we tried to remove details from errors but not how it was implemented. Should be fine.
There was a problem hiding this comment.
For what it's worth, my understanding is that (de)cipher.final() throws if there are encryption/decryption errors.
|
There's also a no longer accurate comment in encrypt.js saying that the crypto API doesn't support AAD. Though I doubt we actually want to incur the compatibility issues of changing to follow the suggestion there. |
Inspired by this comment from @glasser.