Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line input to meteor shell #7562

Merged
merged 3 commits into from Aug 3, 2016
Merged

Conversation

@benjamn
Copy link
Member

@benjamn benjamn commented Aug 3, 2016

There is unfortunately no way to access the special Recoverable constructor defined in node/lib/repl.js unless we temporarily use the defaultEval function, trigger a recoverable error, and capture its .constructor property. Fortunately we are that clever.

Fixes #7504.

@benjamn benjamn added this to the Release 1.4.1 milestone Aug 3, 2016
@benjamn benjamn self-assigned this Aug 3, 2016
@benjamn benjamn force-pushed the meteor-shell-multi-line-input branch to 80aee98 Aug 3, 2016
benjamn added 3 commits Aug 3, 2016
There is unfortunately no way to access the special Recoverable
constructor defined in node/lib/repl.js unless we temporarily use the
defaultEval function, trigger a recoverable error, and capture its
.constructor property. Fortunately we are that clever.

Fixes #7504.
Related to #7504.
@benjamn benjamn force-pushed the meteor-shell-multi-line-input branch from 80aee98 to 44cf6bb Aug 3, 2016
@benjamn benjamn merged commit c0a3698 into devel Aug 3, 2016
4 checks passed
4 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant