New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misbehaving promise polyfill #7569

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
1 participant
@benjamn
Member

benjamn commented Aug 3, 2016

The phantomjs-prebuilt package (typically installed here) now depends on a Promise polyfill package called es6-promise, which misbehaves by overwriting the global.Promise constructor. This becomes a problem when Meteor tools code attempts to call Promise.prototype.await that are added by our (well-behaved) runtime setup code, because global.Promise is no longer the same as the version of Promise that we augmented.

@benjamn benjamn merged commit f4e5ff9 into devel Aug 3, 2016

3 of 4 checks passed

ci/circleci CircleCI is running your tests
Details
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment