New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop minifying server files #7572

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
1 participant
@benjamn
Member

benjamn commented Aug 3, 2016

Though UglifyJS unfortunately does not support many new ES2015+ features, and its harmony branch is not quite stable yet, we can mitigate part of the problem by avoiding using the uglify-js package for server files.

benjamn added some commits Aug 1, 2016

Don't minify non-web .js files.
Fixes #7479, #7441, and similar issues for server-only files that
contain syntax supported by Node 4 but not supported by UglifyJS.
Upgrade uglify-js to version 2.7.0.
This version still doesn't support many ES2015 features, but we might as
well use the latest stable version.
Don't minify non-web .css files.
We shouldn't be processing .css files on the server anyway, because of a
similar restriction in packages/meteor/plugin/basic-file-types.js, but
it seemed wise to enforce that restriction redundantly here.

@benjamn benjamn merged commit 6bb2cd4 into devel Aug 3, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abernix abernix deleted the stop-minifying-server-files branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment