Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop minifying server files #7572

Merged
merged 3 commits into from Aug 3, 2016
Merged

Stop minifying server files #7572

merged 3 commits into from Aug 3, 2016

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Aug 3, 2016

Though UglifyJS unfortunately does not support many new ES2015+ features, and its harmony branch is not quite stable yet, we can mitigate part of the problem by avoiding using the uglify-js package for server files.

This version still doesn't support many ES2015 features, but we might as
well use the latest stable version.
Fixes #7479, #7441, and similar issues for server-only files that
contain syntax supported by Node 4 but not supported by UglifyJS.
We shouldn't be processing .css files on the server anyway, because of a
similar restriction in packages/meteor/plugin/basic-file-types.js, but
it seemed wise to enforce that restriction redundantly here.
@benjamn benjamn merged commit 6bb2cd4 into devel Aug 3, 2016
@abernix abernix deleted the stop-minifying-server-files branch June 6, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant