Move server-side component of meteor shell into a package.
#7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added
Type:Feature
known-fix
in-development
benjamn
force-pushed
the
extract-shell-server-as-package
branch
3 times, most recently
from
c25b4d5
to
c1bac41
Compare
This will make it much easier to fix bugs and make improvements going forward, since they won't have to wait for the next release of Meteor. One functional change: when the parent process exits, it no longer forces all connected shell clients to disconnect, which is actually a more convenient behavior, because it gives the clients a chance to reconnect when/if the server starts up again, and it's easy enough to kill the clients if that's what you want.
benjamn
force-pushed
the
extract-shell-server-as-package
branch
from
c1bac41
to
6de46cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it much easier to fix bugs and make improvements going forward, since they won't have to wait for the next release of Meteor.
Inspired by #7623, which could have been fixed immediately if this package already existed.
One functional change: when the parent process exits, it no longer forces all connected shell clients to disconnect, which is actually a more convenient behavior, because it gives the clients a chance to reconnect when/if the server starts up again, and it's easy enough to kill the clients if that's what you want.