New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server-side component of `meteor shell` into a package. #7624

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Projects
None yet
1 participant
@benjamn
Member

benjamn commented Aug 10, 2016

This will make it much easier to fix bugs and make improvements going forward, since they won't have to wait for the next release of Meteor.

Inspired by #7623, which could have been fixed immediately if this package already existed.

One functional change: when the parent process exits, it no longer forces all connected shell clients to disconnect, which is actually a more convenient behavior, because it gives the clients a chance to reconnect when/if the server starts up again, and it's easy enough to kill the clients if that's what you want.

@benjamn benjamn added this to the Release 1.4.1 milestone Aug 10, 2016

@benjamn benjamn self-assigned this Aug 10, 2016

@benjamn benjamn force-pushed the extract-shell-server-as-package branch 3 times, most recently from c25b4d5 to c1bac41 Aug 10, 2016

Move server-side component of `meteor shell` into a package.
This will make it much easier to fix bugs and make improvements going
forward, since they won't have to wait for the next release of Meteor.

One functional change: when the parent process exits, it no longer forces
all connected shell clients to disconnect, which is actually a more
convenient behavior, because it gives the clients a chance to reconnect
when/if the server starts up again, and it's easy enough to kill the
clients if that's what you want.

@benjamn benjamn force-pushed the extract-shell-server-as-package branch from c1bac41 to 6de46cf Aug 10, 2016

@benjamn benjamn merged commit 3c7f837 into devel Aug 11, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment