Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blaze properly #7633

Merged
merged 10 commits into from
Aug 29, 2016
Merged

Remove blaze properly #7633

merged 10 commits into from
Aug 29, 2016

Conversation

tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Aug 12, 2016

Removing packages at https://github.com/meteor/blaze from the repository.

Follow up to #7619

@benjamn:

  • Do we like packages-for-isopackets?
  • We may need to update jenkins to pull submodules too.
  • Anywhere else we might need to pull submodules?

Otherwise version gravity ends up putting us on super old versions.

I'm not sure what the "correct" constraint is here. This may be overly
restrictive, but I suspect choosing the versions from the last release
before making this change will end up being the sensible choice.
I guess it didn't need it earlier for some reason to do with
isopackets, but it does cause self-test tests to fail.
Let's see how we go now
Previously didn't cause a problem because `static-html` was a core pkg
@tmeasday tmeasday merged commit 64f15f1 into devel Aug 29, 2016
@tmeasday
Copy link
Contributor Author

Merged to devel! Let's hope it doesn't cause any more problems ;)

@laosb laosb deleted the remove-blaze-properly branch August 29, 2016 05:33
@benjamn
Copy link
Contributor

benjamn commented Sep 8, 2016

Hmm, boilerplate-generator still depends on spacebars-compiler and spacebars, which were removed in afc165e. When I run a command like meteor --help, I get the error

Error: Depending on unknown package spacebars
    at Error (native)
    at processUse (/tools/isobuild/package-source.js:1707:15)
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/ben/meteor/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
    at /tools/isobuild/package-source.js:1717:9
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/ben/meteor/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
    at PackageSource.getPackagesToLoadFirst (/tools/isobuild/package-source.js:1712:7)
    at IsopackCache._ensurePackageLoaded (/tools/isobuild/isopack-cache.js:238:39)
    at /tools/isobuild/isopack-cache.js:72:14
...

@tmeasday
Copy link
Contributor Author

tmeasday commented Sep 8, 2016

@benjamn have initialized the submodule? (in your checkout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants