Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Preventing undefined callback from being passed into the forgotPassword Method #7968
changed the title from
Preventing `undefined` callback from being passed into the `forgotPassword` Method
Preventing undefined callback from being passed into the forgotPassword Method
Oct 26, 2016
referenced this pull request
Oct 26, 2016
It looks like CircleCI (and Travis too!) couldn't access the package server when that test ran. Not sure what happened there, but it does appear to be okay again now. Maybe it's just really busy today. You can ping me to trigger retries on the tests too if you need to. :)
Haven't had a chance to review this otherwise yet. ;)
Great, thanks @abernix - I've updated the test description. I'm always a bit nervous when it comes to updating older commit messages (force pushing really scares me!) - am I okay to leave the original commit message without the issue # for now? (I mentioned it in the last commit message). I'll be sure to include an issue # in future PR commit messages. Thanks!
Yeah, it's fine; I wouldn't worry about it this time. But good on adding it to the test name. And force pushing should absolutely scare you!