Rely on npm babel-runtime instead of Meteor helper implementations #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many tests were broken by the initial version of this pull request, since we weren't installing |
benjamn
force-pushed
the
babel-runtime-revamp
branch
from
ca669e1
to
98f6e46
Compare
In light of issues like #7956, I would very much like for app developers to be responsible for providing node_modules/babel-runtime, and for the Meteor babel-runtime package to stop attempting to implement a subset of the helpers.
At this point, the only dependencies installed in this way are babel-runtime and meteor-node-stubs, but that set of packages will expand in the future as we move more dependencies to npm.
Though this may seem like a significant change, this package will still work for older apps as long as the developer follows the instructions about installing the babel-runtime npm package. Helps with #7956.
Tests were broken by the new dependency on the babel-runtime npm package, but fortunately all those tests run `meteor --prepare-app` whenever an app is created by a self-test, so this change should fix most of the breakages.
Some tests disable the --prepare-app step, but still need babel-runtime to be installed.
benjamn
force-pushed
the
babel-runtime-revamp
branch
from
98f6e46
to
6b6a71b
Compare
This is another way to fix the bug I previously fixed by passing options.allowSyntaxError to optimisticReadJsonOrNull. To reproduce the bug (and/or verify that it is fixed), run the following commands in a terminal: rm -rf meteor/packages/npm-mongo/.npm meteor/meteor --get-ready Before these two commits, optimisticReadJsonOrNull would throw a SyntaxError when reading one of the .meteor-portable files because an asynchronous write to the same file had not yet finished.
This extraction was necessary because importing tools/cli/commands.js is not entirely side-effect-free, and was interfering with older tests.
This test has been failing intermittently on Circle CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The more I've thought about the underlying issues involved in #7956, the more I believe the time has come for Meteor to stop providing custom implementations of
babel-runtime/helpers/*and instead simply rely on the npmbabel-runtimepackage.This pull request adds
babel-runtimeto the defaultpackage.jsonfile for new apps (a lameteor-node-stubs), installs those basic packages when runningmeteor test-packages(which is something we should have been doing all along), simplifies the Meteorbabel-runtimepackage (it now throws an error ifbabel-runtimehas not been installed), and cleans up some other logic that no longer matters.I'm torn about whether to include this in 1.4.2.1 or wait for 1.4.3, though I believe it is the most reliable fix for #7956, which is (rightfully) in the 1.4.2.1 milestone.