New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.2.2 (and 1.4.2.3) #8044

Merged
merged 39 commits into from Nov 17, 2016

Conversation

Projects
None yet
@benjamn
Member

benjamn commented Nov 10, 2016

Minor follow-up release to Meteor 1.4.2.1.

In addition to what's currently on devel, here are the issues I'm hoping to address with this release:

Detection of newly added files:

Reify-related issues (possibly to be postponed to 1.4.3):

@benjamn benjamn added this to the Release 1.4.2.2 milestone Nov 10, 2016

@benjamn benjamn self-assigned this Nov 10, 2016

sebakerckhof and others added some commits Nov 4, 2016

Update statOrNull method of cached Resolver objects.
This solves a problem that sometimes occurs when new modules are added
to an app but the cached Resolver object cannot find them because its
statOrNull method is still using a previous instance of the
corresponding ImportScanner.

Related issues and comments:

https://forums.meteor.com/t/meteor-not-detecting-new-files/31151
meteor-vue/vue-meteor#80
#7975 (comment)
#8008

@benjamn benjamn force-pushed the release-1.4.2.2 branch from 34f91c4 to 61ada2d Nov 10, 2016

@benjamn benjamn added the in progress label Nov 10, 2016

@pozylon

This comment has been minimized.

pozylon commented Nov 11, 2016

Very happy to see you guys adding new features to the accounts system and minimongo.

Scaffold an official project structure
Scaffold an official project structure
Add --bare option to meteor create

Notice scaffold options on meteor create

add full skeleton

add spaces

remove shell-server package from skew-full + add description of new packages

Add --bare option to meteor create

Notice scaffold options on meteor create

add full skeleton

add spaces

remove shell-server package from skew-full + add description of new packages

improve PR

resolve conflict

Fix rebase

fix static-assets readme

Fix tipo

Remove insecure and auto publish packages

Remove useraccounts-configuration.js

add tests

fix PR
@laosb

This comment has been minimized.

Collaborator

laosb commented Nov 12, 2016

@benjamn Is it OK to add a compatibility breaking change (accounts-facebook splitting)in a patch version?

@benjamn

This comment has been minimized.

Member

benjamn commented Nov 12, 2016

@laosb You might be right… how much do those changes break backwards compatibility? We could always release those packages separately, later.

@laosb

This comment has been minimized.

Collaborator

laosb commented Nov 13, 2016

Basically if users update, they need to add one more package to get config UI.

sebakerckhof and others added some commits Oct 2, 2016

Preventing undefined callback from being passed into the forgotPasswo…
…rd Method, which in turn prevents unnecessary audit-argument-checks warnings.
Fix options.transformFilename behavior in files.cp_r.
The options.transformFilename function is only supposed to transform
target file names, not the names of source files to be copied.

This behavior was broken by c5809a4
between Meteor 1.4.0.1 and 1.4.1. Thank goodness for `git bisect`!

The biggest symptom of this mistake was that `meteor create --package`
no longer created files based on the ~fs-name~.js and ~fs-name~-tests.js
template files.

This probably merits a 1.4.1.4 release in addition to 1.4.2.2.
Allow lazy api.mainModule modules.
If you call api.mainModule(path, where, { lazy: true }), that main
module will not be evaluated until other code imports it at runtime, and
won't even be bundled if no other code imports it.

Closes #6132.
Strip unnecessary imports for packages with no modules.
Note that even an empty package needs to define Package[name] = {}, so
that other packages can tell at runtime whether it's installed.

Fixes #7927.

@benjamn benjamn force-pushed the release-1.4.2.2 branch from de5325d to 41713da Nov 14, 2016

@benjamn

This comment has been minimized.

Member

benjamn commented Nov 14, 2016

@laosb After thinking about it over the weekend, I've decided to remove the accounts-facebook reorganization changes from this release, so that the 1.4.2.2 will be smoother. We should still release new versions of those packages immediately after releasing 1.4.2.2.

benjamn added some commits Nov 15, 2016

Bump $BUNDLE_VERSION to 4.7.1 before rebuilding dev bundle.
This build includes another attempt to include python.exe reliably in
the Windows dev bundle, thanks to https://github.com/winpython/winpython.
@benjamn

This comment has been minimized.

Member

benjamn commented Nov 15, 2016

Please run meteor update --release 1.4.2.2-rc.1 and test any functionality that's important to you. I'd like to do the final release today or tomorrow. Also please let me know about any changes that I missed that can't wait for the next release.

@abernix

This comment has been minimized.

Member

abernix commented Nov 15, 2016

I likely won't have a chance to test this tonight (your today).

I'm not aware of any other issues which cannot wait for the next release. The only other 'trending' issue that I've seen in the last couple weeks is that Uglify's lack of harmony features (on the published branch) seems to be rearing its head more and more (#8020, #7994, #5517). I also haven't had an opportunity to verify that those would be fixed with the harmony branch though so maybe that would be a better fit for 1.4.3 (reify, babel, etc.).

@benjamn

This comment has been minimized.

Member

benjamn commented Nov 15, 2016

Yeah, last I checked the harmony branch of UglifyJS was not ready for production, and was not a smooth upgrade. Crazy that they've survived this long without catching up to the times.

@abernix

This comment has been minimized.

Member

abernix commented Nov 16, 2016

@benjamn I'd suggest merging #8045 as well. It implements code-style improvements to the new "skel" introduced with #7807 (which is surfacing for the first time in 1.4.2.2 thanks to 0466fdd above). It'd be nice to just use the "improved" version.

@benjamn

This comment has been minimized.

Member

benjamn commented Nov 16, 2016

After taking a closer look at #8045, even though Meteor 1.4.2.2 is already final (but not yet "recommended"), I think it's worth immediately publishing a 1.4.2.3 release with @dburles' changes. Lots of folks are going to encounter those skeleton files before they know anything else about Meteor, so it seems really important for them to demonstrate good style and code structure.

@benjamn benjamn changed the title from Release 1.4.2.2 to Release 1.4.2.2 (and 1.4.2.3) Nov 17, 2016

@abernix

This comment has been minimized.

Member

abernix commented Nov 17, 2016

Good call on the move for 1.4.2.3. Also, if it's any assurance, I saw no issues with Meteor 1.4.2.2-rc.1 in my tests on my own apps.

@benjamn benjamn merged commit dc0acea into master Nov 17, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@QHose

This comment has been minimized.

QHose commented Nov 18, 2016

Hi Ben,

I used your suggested beta for the file not change issue. It works better. But I noticed meteor does not recognize small changes consistently. E.g. When I make a A HREF with too much quotes. I save, then meteor shows the error. I remove the extra quote but it does not update.

<a href="{{URL_Youtube_concept_behind}}"" target="_blank">explained in this video</a>

to

<a href="{{URL_Youtube_concept_behind}}" target="_blank">explained in this video</a>

I saw the same thing yesterday when I had too much blaze }}}.

{{template}}}

to

{{template}}

@QHose

This comment has been minimized.

QHose commented Nov 18, 2016

mmm, could it be I press save too soon... and meteor is not yet checking my files?

@abernix

This comment has been minimized.

Member

abernix commented on 41713da Nov 18, 2016

👍 Can this also be added to the https://install.meteor.com/ script? (two separate places)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment