Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
benjamn
added this to the Release 1.4.3 milestone
Nov 28, 2016
benjamn
merged commit ac86594
into
devel
Nov 28, 2016
benjamn
referenced this pull request
Nov 28, 2016
Closed
Add `meteor npm install` step to installer #8095
This comment has been minimized.
This comment has been minimized.
|
Revert 41713da now? |
benjamn
referenced this pull request
Dec 5, 2016
Closed
Meteor should install npm packages automatically (feature request) #6848
added a commit
that referenced
this pull request
Feb 12, 2017
added a commit
that referenced
this pull request
Feb 13, 2017
added a commit
that referenced
this pull request
Feb 13, 2017
added a commit
that referenced
this pull request
Feb 27, 2017
glasser
referenced this pull request
Feb 27, 2017
Merged
Remove `meteor npm install` instruction #8433
added a commit
that referenced
this pull request
Feb 28, 2017
added a commit
that referenced
this pull request
Mar 1, 2017
hwillson
referenced this pull request
Oct 17, 2017
Closed
Run meteor npm install if node_modules is not present #202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
benjamn commentedNov 28, 2016
•
edited
Although I have said I do not think Meteor should run
npm installautomatically to update applicationnode_modules, my real concern is that Meteor should not interfere with your preferrednode_modules-related workflow, be itnpm,npm-shinkwrap.json,shrinkpack,yarn+yarn.lock, checking yournode_modulesinto git/mercurial/cvs, or whatever other scheme you currently have (or might adopt in the future).Automatically installing
node_modulesfrom the defaultpackage.jsonfile when a new app is created will eliminate real confusion, and should not interfere with any workflows, because there is no opportunity to establish another workflow before Meteor runsnpm installthe very first time.Addresses #6848.
May make #8095 unnecessary?