Install npm dependencies automatically when creating apps. #8108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although I have said I do not think Meteor should run `npm install` automatically to update application node_modules, my real concern is that Meteor should not interfere with your preferred node_modules-related workflow, be it npm, npm-shinkwrap.json, yarn, yarn.lock, checking your node_modules into git/mercurial/cvs, or whatever other scheme you have. Automatically installing node_modules from the default package.json file when a new app is created will eliminate real confusion, and should not interfere with any workflows, because there is no opportunity to establish another workflow before Meteor runs `npm install` the very first time.
|
Revert 41713da now? |
benjamn
added a commit
that referenced
this pull request
Feb 12, 2017
abernix
pushed a commit
that referenced
this pull request
Feb 13, 2017
benjamn
added a commit
that referenced
this pull request
Feb 13, 2017
glasser
added a commit
that referenced
this pull request
Feb 27, 2017
As of #8108, `meteor create` runs `meteor npm install`, so it doesn't need to tell you do to do so.
abernix
pushed a commit
that referenced
this pull request
Feb 28, 2017
As of #8108, `meteor create` runs `meteor npm install`, so it doesn't need to tell you do to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Although I have said I do not think Meteor should run
npm installautomatically to update applicationnode_modules, my real concern is that Meteor should not interfere with your preferrednode_modules-related workflow, be itnpm,npm-shinkwrap.json,shrinkpack,yarn+yarn.lock, checking yournode_modulesinto git/mercurial/cvs, or whatever other scheme you currently have (or might adopt in the future).Automatically installing
node_modulesfrom the defaultpackage.jsonfile when a new app is created will eliminate real confusion, and should not interfere with any workflows, because there is no opportunity to establish another workflow before Meteor runsnpm installthe very first time.Addresses #6848.
May make #8095 unnecessary?