Join GitHub today
Update to Cordova 6.4.0 #8239
Apologies for the delay on reviewing this. This took me quite some time to evaluate (due to environmental delays, mostly: VirtualBox, Windows, Android SDK, etc.) but I'm fairly confident that these changes are all correct. I tested on Mac (Android and iOS) and Windows (Android only, as no iOS). Some points worth discussing before introducing this to (hopefully?) Meteor 1.4.3:
Thanks for the review. I have conducted tests on Windows 10, Xubuntu 16.04 and newest MacOS.
Yeah, cordova page seems to be outdated. The SDK needed is indeed 25 -> apache/cordova-android@35b0ba6#diff-6899c18ece5b4dbbb91204b8356126d1 I will make PR to the guide.
About HCP - yes, it changes the compatibility version for sure because the plugin versions used by the packages like webapp, statusbar etc have been changed.
Ok, I'm in favor of this landing in 1.4.3. The remaining action items are doc related. We'll need to update
History.md with a blurb similar to the 1.4.2 upgrade to 6.2.0.
Please do open that PR on the Guide, @wojtkowiak and link it to this issue, if you will.
@abernix, your review noted the unexpected dependency on CocoaPods. @wojtkowiak intended to verify but I didn't find any further comment. I just wanted to close the loop for others as our team too found the dependency unexpected. Maybe this warrants a note in history.md, but since that references this PR, a quick comment here seemed sufficient.