/meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts-google reorganize #8275

Merged
merged 4 commits into from Jan 25, 2017

Conversation

Reviewers

@abernix abernix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@laosb @abernix @benjamn
@laosb
Collaborator

laosb commented Jan 21, 2017

#7715
Related (the Facebook one): #7728

Hi there, long time no see!

Having my winter vacation. Thinking accounts-google is popular, I reorganized accounts-google this time. I haven't got some time to test it, so getting someone to test it would be helpful.

I can't guarantee when I can do this on accounts-twitter, accounts-github and others. Pull requests for those are always encouraged.

laosb added some commits Jan 21, 2017

@laosb
Accounts-google reorganize [Not finished yet]
Loading status checks…
08de1c9
@laosb
Accounts-google reorganized.
Loading status checks…
9fa2a0e
@laosb
Move css to config-ui.
Loading status checks…
1edd1d0
@laosb

This comment has been minimized.

Sign in to view
Collaborator

laosb commented Jan 21, 2017

Travis CI said:

An error occurred while generating the build script.

Don't know what's happening.
@abernix

abernix requested changes Jan 24, 2017
View changes

Thanks, @laosb! I've commented within on just a few things...

packages/google/README.md Outdated
** Deprecated, use facebook-oauth instead**

This comment has been minimized.

Sign in to view
Copy link
@abernix

abernix Jan 24, 2017

Member

This should be google-oauth.

This comment has been minimized.

Sign in to view
Copy link
@laosb

laosb Jan 25, 2017

Collaborator

Right, my copying issue.
packages/google-oauth/package.js Outdated
api.use('oauth', ['client', 'server']);
api.use('http', ['server']);
api.use(['underscore', 'service-configuration'], ['client', 'server']);
api.use(['random', 'templating@1.2.13'], 'client');

This comment has been minimized.

Sign in to view
Copy link
@abernix

abernix Jan 24, 2017

Member

Is there a particular reason we need to depend on not only templating but specifically templating@1.2.13? The facebook-oauth package doesn't use templating at all.
packages/google-config-ui/package.js Outdated
});
Package.onUse(function(api) {
api.use('templating@1.2.13', 'client');

This comment has been minimized.

Sign in to view
Copy link
@abernix

abernix Jan 24, 2017

Member

Was there a reason for depending specifically on 1.2.13? We do this in facebook-config-ui but I don't immediately remember why.

This comment has been minimized.

Sign in to view
Copy link
@laosb

laosb Jan 25, 2017

Collaborator

I guess this was added for the release version pinning?
packages/google-config-ui/package.js Outdated
@@ -0,0 +1,13 @@
Package.describe({
summary: "Blaze configuration templates for Google OAuth.",
version: "1.0.0-beta.1"

This comment has been minimized.

Sign in to view
Copy link
@abernix

abernix Jan 24, 2017

Member

Was there a reason to -beta.1 this?

This comment has been minimized.

Sign in to view
Copy link
@laosb

laosb Jan 25, 2017 •
edited

Collaborator

That's copied from facebook-config-ui. Might because the 1.4.3 beta process. I will remove it.
packages/google-oauth/package.js Outdated
api.use(['underscore', 'service-configuration'], ['client', 'server']);
api.use(['random', 'templating@1.2.13'], 'client');
api.export('Google');

This comment has been minimized.

Sign in to view
Copy link
@abernix

abernix Jan 24, 2017

Member

Nit pick, but this should be after api.addFiles just to match the Facebook package

@abernix abernix referenced this pull request Jan 24, 2017

Merged

accounts-twitter reorganize #8283

@laosb
Fix according to @abernix 's review.
Loading status checks…
b607506
@abernix

abernix approved these changes Jan 25, 2017
View changes

@benjamn benjamn merged commit 293b3d9 into devel Jan 25, 2017
4 checks passed

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@laosb laosb referenced this pull request Jan 31, 2017

Merged

Accounts-weibo reorganize #8302

@benjamn benjamn referenced this pull request Feb 9, 2017

Closed

Upgraders for reorganized accounts service packages #8345

abernix added a commit that referenced this pull request Feb 10, 2017

@abernix
Add an upgrader which modifies `accounts-*` packages automatically. 
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: https://github.com/meteor/meteor/pull/7728œ
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
347ec72

abernix added a commit that referenced this pull request Feb 10, 2017

@abernix
Add an upgrader which modifies `accounts-*` packages automatically. 
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: https://github.com/meteor/meteor/pull/7728œ
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
d2528e1

abernix added a commit that referenced this pull request Feb 10, 2017

@abernix
Add an upgrader which modifies `accounts-*` packages automatically. 
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
3bb887f

@abernix abernix referenced this pull request Feb 10, 2017

Merged

Touch-ups for Accounts Package Changes #8346

@abernix abernix deleted the accounts-google-reorg branch Feb 10, 2017

abernix added a commit to abernix/meteor that referenced this pull request Feb 10, 2017

@abernix
Add an upgrader which modifies `accounts-*` packages automatically. 
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 meteor#7715 (comment)

 Relates to:

  * facebook: meteor#7728
  * github: meteor#8303
  * google: meteor#8275
  * meetup: meteor#8231
  * meteor-developer: meteor#8305
  * twitter: meteor#8283
  * weibo: meteor#8302
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
d062cae

abernix added a commit that referenced this pull request Feb 10, 2017

@abernix
Add an upgrader which modifies `accounts-*` packages automatically. 
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
f4d677f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment