Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts-google reorganize #8275

Merged
merged 4 commits into from Jan 25, 2017
Merged

Accounts-google reorganize #8275

merged 4 commits into from Jan 25, 2017

Conversation

laosb
Copy link
Contributor

@laosb laosb commented Jan 21, 2017

#7715
Related (the Facebook one): #7728

Hi there, long time no see!

Having my winter vacation. Thinking accounts-google is popular, I reorganized accounts-google this time. I haven't got some time to test it, so getting someone to test it would be helpful.

I can't guarantee when I can do this on accounts-twitter, accounts-github and others. Pull requests for those are always encouraged.

@laosb
Copy link
Contributor Author

laosb commented Jan 21, 2017

Travis CI said:

An error occurred while generating the build script.

Don't know what's happening.

Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @laosb! I've commented within on just a few things...

** Deprecated, use facebook-oauth instead**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be google-oauth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, my copying issue.

api.use('oauth', ['client', 'server']);
api.use('http', ['server']);
api.use(['underscore', 'service-configuration'], ['client', 'server']);
api.use(['random', 'templating@1.2.13'], 'client');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason we need to depend on not only templating but specifically templating@1.2.13? The facebook-oauth package doesn't use templating at all.

});

Package.onUse(function(api) {
api.use('templating@1.2.13', 'client');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for depending specifically on 1.2.13? We do this in facebook-config-ui but I don't immediately remember why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was added for the release version pinning?

@@ -0,0 +1,13 @@
Package.describe({
summary: "Blaze configuration templates for Google OAuth.",
version: "1.0.0-beta.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to -beta.1 this?

Copy link
Contributor Author

@laosb laosb Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's copied from facebook-config-ui. Might because the 1.4.3 beta process. I will remove it.

api.use(['underscore', 'service-configuration'], ['client', 'server']);
api.use(['random', 'templating@1.2.13'], 'client');

api.export('Google');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick, but this should be after api.addFiles just to match the Facebook package

@benjamn benjamn merged commit 293b3d9 into devel Jan 25, 2017
@laosb laosb mentioned this pull request Jan 31, 2017
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
@abernix abernix deleted the accounts-google-reorg branch February 10, 2017 09:49
abernix added a commit to abernix/meteor that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 meteor#7715 (comment)

 Relates to:

  * facebook: meteor#7728
  * github: meteor#8303
  * google: meteor#8275
  * meetup: meteor#8231
  * meteor-developer: meteor#8305
  * twitter: meteor#8283
  * weibo: meteor#8302
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants