Accounts-google reorganize #8275
Merged
Conversation
|
Travis CI said: Don't know what's happening. |
packages/google/README.md
Outdated
| ** Deprecated, use facebook-oauth instead** |
abernix
Jan 24, 2017
Member
This should be google-oauth.
This should be google-oauth.
laosb
Jan 25, 2017
Author
Contributor
Right, my copying issue.
Right, my copying issue.
packages/google-oauth/package.js
Outdated
| api.use('oauth', ['client', 'server']); | ||
| api.use('http', ['server']); | ||
| api.use(['underscore', 'service-configuration'], ['client', 'server']); | ||
| api.use(['random', 'templating@1.2.13'], 'client'); |
abernix
Jan 24, 2017
Member
Is there a particular reason we need to depend on not only templating but specifically templating@1.2.13? The facebook-oauth package doesn't use templating at all.
Is there a particular reason we need to depend on not only templating but specifically templating@1.2.13? The facebook-oauth package doesn't use templating at all.
packages/google-config-ui/package.js
Outdated
| }); | ||
|
|
||
| Package.onUse(function(api) { | ||
| api.use('templating@1.2.13', 'client'); |
abernix
Jan 24, 2017
Member
Was there a reason for depending specifically on 1.2.13? We do this in facebook-config-ui but I don't immediately remember why.
Was there a reason for depending specifically on 1.2.13? We do this in facebook-config-ui but I don't immediately remember why.
laosb
Jan 25, 2017
Author
Contributor
I guess this was added for the release version pinning?
I guess this was added for the release version pinning?
packages/google-config-ui/package.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| Package.describe({ | |||
| summary: "Blaze configuration templates for Google OAuth.", | |||
| version: "1.0.0-beta.1" | |||
abernix
Jan 24, 2017
Member
Was there a reason to -beta.1 this?
Was there a reason to -beta.1 this?
laosb
Jan 25, 2017
•
Author
Contributor
That's copied from facebook-config-ui. Might because the 1.4.3 beta process. I will remove it.
That's copied from facebook-config-ui. Might because the 1.4.3 beta process. I will remove it.
packages/google-oauth/package.js
Outdated
| api.use(['underscore', 'service-configuration'], ['client', 'server']); | ||
| api.use(['random', 'templating@1.2.13'], 'client'); | ||
|
|
||
| api.export('Google'); |
abernix
added a commit
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
abernix
added a commit
to abernix/meteor
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` meteor#7715 (comment) Relates to: * facebook: meteor#7728 * github: meteor#8303 * google: meteor#8275 * meetup: meteor#8231 * meteor-developer: meteor#8305 * twitter: meteor#8283 * weibo: meteor#8302
abernix
added a commit
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
#7715
Related (the Facebook one): #7728
Hi there, long time no see!
Having my winter vacation. Thinking accounts-google is popular, I reorganized accounts-google this time. I haven't got some time to test it, so getting someone to test it would be helpful.
I can't guarantee when I can do this on accounts-twitter, accounts-github and others. Pull requests for those are always encouraged.