Accounts-weibo reorganize #8302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you saying that Weibo wasn't working before you made this change? Do you think this is an important package to get working again? Would it be difficult? |
|
Just reviewed their API document, Weibo's OAuth API didn't change since the package's last update. So it should be fine. Can't test since my Weibo.com account have gotten banned for some reason(that I don't know) 2 years ago. |
abernix
suggested changes
Feb 8, 2017
packages/accounts-weibo/package.js
Outdated
| }); | ||
|
|
||
| Package.onUse(function(api) { | ||
| api.use('accounts-base', ['client', 'server']); | ||
| // Export Accounts (etc) to packages using this one. | ||
| api.imply('accounts-base', ['client', 'server']); | ||
| api.use('accounts-oauth', ['client', 'server']); | ||
| api.use('weibo', ['client', 'server']); | ||
| api.use('twitter-oauth'); | ||
| api.imply('twitter-oauth'); |
There was a problem hiding this comment.
These should both be weibo, not twitter.
Seemingly copy-paste residue in the PR, but this is the Weibo package it should be Weibo, not Twitter.
abernix
approved these changes
Feb 8, 2017
abernix
added a commit
that referenced
this pull request
Feb 8, 2017
benjamn
pushed a commit
that referenced
this pull request
Feb 8, 2017
abernix
added a commit
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
abernix
added a commit
to abernix/meteor
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` meteor#7715 (comment) Relates to: * facebook: meteor#7728 * github: meteor#8303 * google: meteor#8275 * meetup: meteor#8231 * meteor-developer: meteor#8305 * twitter: meteor#8283 * weibo: meteor#8302
abernix
added a commit
that referenced
this pull request
Feb 10, 2017
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7715
Related:
Weibo looks a little different from other ones. I can't even ensure it works or not previously since this package is not actively maintained.