-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Accounts-weibo reorganize #8302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you saying that Weibo wasn't working before you made this change? Do you think this is an important package to get working again? Would it be difficult? |
Just reviewed their API document, Weibo's OAuth API didn't change since the package's last update. So it should be fine. Can't test since my Weibo.com account have gotten banned for some reason(that I don't know) 2 years ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. I'll fix this typo, but otherwise the commits look identical to the other package changes.
packages/accounts-weibo/package.js
Outdated
}); | ||
|
||
Package.onUse(function(api) { | ||
api.use('accounts-base', ['client', 'server']); | ||
// Export Accounts (etc) to packages using this one. | ||
api.imply('accounts-base', ['client', 'server']); | ||
api.use('accounts-oauth', ['client', 'server']); | ||
api.use('weibo', ['client', 'server']); | ||
api.use('twitter-oauth'); | ||
api.imply('twitter-oauth'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should both be weibo
, not twitter
.
Seemingly copy-paste residue in the PR, but this is the Weibo package it should be Weibo, not Twitter.
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` meteor#7715 (comment) Relates to: * facebook: meteor#7728 * github: meteor#8303 * google: meteor#8275 * meetup: meteor#8231 * meteor-developer: meteor#8305 * twitter: meteor#8283 * weibo: meteor#8302
The transformations to be made here are: * Existence of `accounts-<service>` **adds** `<service>-config-ui` * Existence of `<service>` **changes to** `<service>-oauth` #7715 (comment) Relates to: * facebook: #7728 * github: #8303 * google: #8275 * meetup: #8231 * meteor-developer: #8305 * twitter: #8283 * weibo: #8302
#7715
Related:
Weibo looks a little different from other ones. I can't even ensure it works or not previously since this package is not actively maintained.