Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts-weibo reorganize #8302

Merged
merged 5 commits into from Feb 8, 2017
Merged

Accounts-weibo reorganize #8302

merged 5 commits into from Feb 8, 2017

Conversation

@laosb
Copy link
Collaborator

@laosb laosb commented Jan 31, 2017

#7715

Related:

Weibo looks a little different from other ones. I can't even ensure it works or not previously since this package is not actively maintained.

@abernix
Copy link
Member

@abernix abernix commented Feb 2, 2017

Are you saying that Weibo wasn't working before you made this change? Do you think this is an important package to get working again? Would it be difficult?

@laosb
Copy link
Collaborator Author

@laosb laosb commented Feb 3, 2017

Just reviewed their API document, Weibo's OAuth API didn't change since the package's last update. So it should be fine. Can't test since my Weibo.com account have gotten banned for some reason(that I don't know) 2 years ago.

Copy link
Member

@abernix abernix left a comment

Thanks for submitting this. I'll fix this typo, but otherwise the commits look identical to the other package changes.

});

Package.onUse(function(api) {
api.use('accounts-base', ['client', 'server']);
// Export Accounts (etc) to packages using this one.
api.imply('accounts-base', ['client', 'server']);
api.use('accounts-oauth', ['client', 'server']);
api.use('weibo', ['client', 'server']);
api.use('twitter-oauth');
api.imply('twitter-oauth');

This comment has been minimized.

@abernix

abernix Feb 8, 2017
Member

These should both be weibo, not twitter.

Seemingly copy-paste residue in the PR, but this is the Weibo package
it should be Weibo, not Twitter.
@abernix
abernix approved these changes Feb 8, 2017
abernix added a commit that referenced this pull request Feb 8, 2017
Including:
 * `github`: #8303
 * `meteor-developer`: #8305
 * `meetup`: #8231
 * `weibo`: #8302
@benjamn benjamn merged commit bdc9872 into devel Feb 8, 2017
4 checks passed
4 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benjamn benjamn added this to the Release 1.4.3 milestone Feb 8, 2017
benjamn added a commit that referenced this pull request Feb 8, 2017
Including:
 * `github`: #8303
 * `meteor-developer`: #8305
 * `meetup`: #8231
 * `weibo`: #8302
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
abernix added a commit to abernix/meteor that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 meteor#7715 (comment)

 Relates to:

  * facebook: meteor#7728
  * github: meteor#8303
  * google: meteor#8275
  * meetup: meteor#8231
  * meteor-developer: meteor#8305
  * twitter: meteor#8283
  * weibo: meteor#8302
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
@abernix abernix deleted the accounts-weibo-reorg branch Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.