Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wired up new github accounts changes to separate the UI from oauth calls #8303

Merged
merged 2 commits into from Feb 8, 2017

Conversation

@hwillson
Copy link
Member

@hwillson hwillson commented Jan 31, 2017

Hi all - this PR relates to issue #7715. It provides the necessary accounts changes for accounts-github (following the structure put in place for accounts-google and accounts-facebook). Let me know if anything should be changed. Thanks!

@abernix
abernix approved these changes Feb 8, 2017
Copy link
Member

@abernix abernix left a comment

LGTM!

abernix added a commit that referenced this pull request Feb 8, 2017
Including:
 * `github`: #8303
 * `meteor-developer`: #8305
 * `meetup`: #8231
 * `weibo`: #8302
@benjamn benjamn merged commit 1c0060f into meteor:devel Feb 8, 2017
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjamn benjamn added this to the Release 1.4.3 milestone Feb 8, 2017
benjamn added a commit that referenced this pull request Feb 8, 2017
Including:
 * `github`: #8303
 * `meteor-developer`: #8305
 * `meetup`: #8231
 * `weibo`: #8302
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
abernix added a commit to abernix/meteor that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 meteor#7715 (comment)

 Relates to:

  * facebook: meteor#7728
  * github: meteor#8303
  * google: meteor#8275
  * meetup: meteor#8231
  * meteor-developer: meteor#8305
  * twitter: meteor#8283
  * weibo: meteor#8302
abernix added a commit that referenced this pull request Feb 10, 2017
 The transformations to be made here are:
   * Existence of `accounts-<service>` **adds** `<service>-config-ui`
   * Existence of `<service>` **changes to** `<service>-oauth`
 #7715 (comment)

 Relates to:

  * facebook: #7728
  * github: #8303
  * google: #8275
  * meetup: #8231
  * meteor-developer: #8305
  * twitter: #8283
  * weibo: #8302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.