New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.2.5 #8311

Merged
merged 8 commits into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@abernix
Member

abernix commented Feb 3, 2017

During the final stages of the release process for Meteor 1.4.2.4 (a bug fix release, #8306) it was realized that it was going to be necessary for developers to take the additional, possibly mandatory, step of running meteor update --all-packages or meteor update modules-runtime. This is because Meteor 1.4.2.4 requires modules-runtime@0.7.8 and its dependency on (NPM) install@0.8.4 to function correctly. See this commit on install or #8213 if you're interested in the logic behind that (important!) change.

Despite the simple solution (stated above) and while this was explained very clearly in the release notes, it was deemed too complex for this point release due to the additional intervention necessary by the developer. Meteor 1.4.2.4 was not (and will not be) marked as recommended (i.e. made official).

In an ideal world meteor-tool could have forced a minimum version for this Atmosphere package to 0.7.8 but due to version unpinning this update would not have been enforced by the constraint-solver. This will likely be addressed in the future.

This release will simply omit 2eab0b2 (and associated changes) although those will remain in the upcoming 1.4.3 (#8123) release with the addition of an "upgrader" designed to take care of this automatically with no additional steps required by the end-developer.

@abernix abernix added the in progress label Feb 3, 2017

@abernix abernix self-assigned this Feb 3, 2017

@abernix abernix referenced this pull request Feb 3, 2017

Merged

Release 1.4.2.x #8306

abernix added some commits Feb 3, 2017

Bumping version of `modules-runtime` to 0.7.8
`modules-runtime@0.7.8` was already released but this part of the commit was included in a larger commit which was reverted.  This simply puts the version in-line with the `devel` branch.

@abernix abernix force-pushed the release-1.4.2.5 branch from 2c99a93 to 7fc3627 Feb 3, 2017

@abernix abernix changed the base branch from devel to master Feb 3, 2017

@@ -13,10 +13,6 @@ if (typeof Profile === "function" &&
};
}

// On the client, make package resolution prefer the "browser" field of
// package.json files to the "main" field.
options.browser = Meteor.isClient;

This comment has been minimized.

@benjamn

benjamn Feb 3, 2017

Member

@abernix Let's not revert this change?

This comment has been minimized.

@abernix

abernix Feb 3, 2017

Member

@benjamn Yes, it shouldn't be reverted and the commit above is actually deceiving as I didn't end up publishing modules-runtime in the release process for rc.0. But this should accurately reflect what was published. I'll fix this.

abernix added some commits Feb 3, 2017

Restore state of modules-runtime@0.7.8 as it was published
This code was reverted in 32140c8 as part of a larger revert, but this particular change should actually remain since it is how modules-runtime@0.7.8 was and is published.  I had initially thought that this commit would also be rolled back (and result in a 0.7.9) but that did not yield the desired result.
@benjamn

benjamn approved these changes Feb 3, 2017

abernix added some commits Feb 3, 2017

@mitar

This comment has been minimized.

Collaborator

mitar commented Feb 7, 2017

Hm, why I am getting that 1.4.2.5 version is available, but there is nothing available in History.md in devel branch about it?

@abernix

This comment has been minimized.

Member

abernix commented Feb 7, 2017

@mitar You can find the History.md for 1.4.2.5 on the release-1.4.2.5 branch. We now have the concept of more than one active release branch in order to release bug fixes at a faster velocity and independent of a more substantial release.

Obviously, we still need to figure out what exactly that means for the devel branch but History.md seems like the most important thing to get updated at the moment. The recent inclusion of this in the docs might be the solution for that. It wasn't updated when the 1.4.2.5 was officially recommended, but it is updated now.

@benjamn benjamn merged commit 1e1833b into master Feb 7, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mitar

This comment has been minimized.

Collaborator

mitar commented Feb 7, 2017

Yes, it is merged now, because this pull request got merged into deve. ;-)

BTW, one cool thing could be to display the segment of history.md file in the console. So one could see there what is new. Instead of having to go to the GitHub.

benjamn added a commit that referenced this pull request Feb 7, 2017

Register package@version constraints for current release.
Package version unpinning (#7084) removed all exact package@=version
constraints derived from the current release.

As we discovered with Meteor 1.4.2.4 (#8306), this meant releases no
longer had any power to enforce package upgrades, which is why the
follow-up Meteor 1.4.2.5 release (#8311) was necessary.

This commit has the same effect as putting package@version in your
.meteor/packages file for every local/core package that your app uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment