Adjusted query string array representation to remove indices. #8342
Conversation
|
Could you also increment the version in |
|
Shoot - sure thing @benjamn, thanks! |
…ackwards compatiable.
abernix
added a commit
that referenced
this pull request
Feb 10, 2017
* Adjusted query string array representation to remove indices. * Increased major version since the new _encodeParams() result is not backwards compatiable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi guys - after some discussion about the implementation provided in PR #8261, it looks like we should adjust the implemented array handling a bit. Right now arrays are encoded with indices like:
While this implementation is somewhat supported by external languages and frameworks, it's not as well supported (by default) as the following query string representation for arrays:
For example, PHP and Rails both expect no indices for arrays.
This PR adjusts the
urlpackage to make sure query string encoded arrays do not include indices. Thanks!