New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery from default dependencies. #8388
Conversation
This commit removes jQuery package from default project skeletons. Also removes it from http package because it didn't use it at all.
Thanks for opening this as a separate issue from the #8327 thread. I think this is reasonable to consider, but we probably need to take inventory of and consider tutorials (and expectations) that may exist out there right now before merging this. Could you actually open the |
Also, can you please enable your CircleCI builds for
|
@abernix Done. As for tutorials and guides, I think we are good, because normally the flow for creating a new project would not change, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for submitting this. I fully agree with your last statement. Merged manually to I've left this PR targeted to |
This should be done in Meteor 1.4.3.2. You can try the latest 1.4.3.2 beta and help confirm by running:
Please report back if you encounter any problems, and thanks for taking care of this! |
If I add jquery from npm, does that mean I have to explicitly import jquery in every js file(assume I use jquery in every js file)? |
You could do |
@haojia321 While I fully agree you should prefer an approach (as @stubailo recommended above) where you $ meteor add jquery
$ meteor npm install jquery --save |
This pull request removes jQuery package from default project skeletons.
Also removes it from http package because it didn't use it at all.