Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery dependency from http package #8389

Merged

Conversation

@maciej-trebacz
Copy link
Contributor

@maciej-trebacz maciej-trebacz commented Feb 17, 2017

This is to remove jQuery as a default dependency from http package, as a part of removing jQuery altogether as a default dependency from Meteor. See #8388 for more details.

@benjamn benjamn added this to the Release 1.5 milestone Feb 18, 2017
Copy link
Member

@abernix abernix left a comment

Thanks for noticing this (and thanks for breaking this into another PR).

It looks like jquery was no longer necessary as of 4e922fd and thus the removal of this dependency is warranted.

@abernix abernix merged commit 705ff31 into meteor:release-1.5 Feb 23, 2017
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abernix
Copy link
Member

@abernix abernix commented Feb 23, 2017

Thanks, @M4v3R!

@abernix
Copy link
Member

@abernix abernix commented Feb 23, 2017

Just realized this was on the release-1.5 branch. I will cherry-pick it onto devel now, but in the future, please open all pull-requests against the devel branch (I should have caught that before I merged, to be fair). Granted, yes, this will be in release 1.5 it's still best if we go from devel to release-*.

abernix added a commit that referenced this pull request Feb 23, 2017
`jquery` is no longer necessary as of 4e922fd and thus the removal of this dependency is warranted.
@maciej-trebacz maciej-trebacz deleted the maciej-trebacz:release-1.5-http-nojquery branch Feb 23, 2017
@abernix abernix modified the milestones: Release 1.4.3.x, Release 1.5 Mar 9, 2017
@abernix
Copy link
Member

@abernix abernix commented Mar 9, 2017

This should be released in Meteor 1.4.3.2. You can try the latest 1.4.3.2 beta and help confirm by running:

meteor update --release 1.4.3.2-beta.0

Please report back if you encounter any problems, and thanks for taking care of this!

@abernix abernix modified the milestones: Release 1.4.3.x, Release 1.4.3.2 Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants