Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Twitter Bootstrap as a smart package. #84

Merged
merged 6 commits into from Apr 26, 2012
Merged

Added Twitter Bootstrap as a smart package. #84

merged 6 commits into from Apr 26, 2012

Conversation

@fivethirty
Copy link
Contributor

@fivethirty fivethirty commented Apr 22, 2012

Accidentally submitted this as a pull request to master the first time becasue I'm bad at reading Wikis. Sorry.

Anyhow...

Pretty straightforward except that Bootstrap includes some .png icon sprites. Had to add support for an "img" data type in Bundle.add_resource in order to handle adding them, which is probably a hack.

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Apr 25, 2012

+1 for this :)

@debergalis
Copy link
Member

@debergalis debergalis commented Apr 26, 2012

This looks great! Just need one change: in production mode, the CSS is going to get minified and served from / instead of /packages/bootstrap/css. So all the links in the CSS files need to be absolute links to /packages/bootstrap/img/...

icons absolute.  this is needed because the
bundler minifies css and serves it from the "/"
directory.
@fivethirty
Copy link
Contributor Author

@fivethirty fivethirty commented Apr 26, 2012

editing bootstrap itself seemed really questionable to me, so i added a new css file that sets the paths to be absolute and is added after the original bootstrap files. tested by deploying to bootstrap-test.meteor.com.

@debergalis
Copy link
Member

@debergalis debergalis commented Apr 26, 2012

sold!

debergalis added a commit that referenced this pull request Apr 26, 2012
Added Twitter Bootstrap as a smart package.
@debergalis debergalis merged commit 4c1f0d5 into meteor:devel Apr 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants