Export "app"

[domq]

As per the comment on line 653, this appears to be the best (only?) way to let users do things like set up a custom error page to catch app-rendering-time exceptions.

This purports to solve #8402

[apollo-cla]

@domq: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[abernix]

Not entirely opposed to this but is this something you weren't able to accomplish using WebApp.connectHandlers.use?

A little more insight into what you've tried might be helpful here.

[stubailo]

Yeah rendering exceptions should be able to be caught with an error middleware on connectHandlers.

[glasser]

As the comment that @domq alluded to says, connect (at least the version Meteor uses) does not recursively search into nested middleware to search for 4-argument error middleware.

[abernix]

Ok, so based on what @glasser is saying, and his own comment here I can understand more now why this is necessary. I hadn't remembered that was the case.

Given that, I'm in favor of this change, however I think we should consider a different name. Currently the proposed API would be WebApp.connectMiddleware, however, this is specifically the "app" middleware, I believe.

Should we call it WebApp.appMiddleware? Or just WebApp.middleware to avoid the redundancy?

EDIT: Actually, maybe this should just be WebApp.app? It's not really middleware at this point, is it? WebApp.server?

[hwillson]

How about WebApp.connectApp? That's what we're really exposing and connect themselves refer to the container that holds the defined middleware (the result of calling the connect() function) as a connect "app". I realize we might not want to expose internal details in an externally available property name (in-case connect is removed at some point), but hey we're already doing that with WebApp.connectHandlers ... 🙂

[abernix]

Any thoughts, @domq?

[domq]

Well I'm honored that you would request my opinion on naming! I suppose I can go with @HughWilson's suggestion or any other ; just let me know your preference, and I'll rebase and resubmit.

…

-- Dominique Quatravaux dominique@quatravaux.org Le 8 mars 2017 2:49 PM, "Jesse Rosenberger" <notifications@github.com> a écrit :

Any thoughts, @domq <https://github.com/domq>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8403 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjdkdBQJePMom8Z6kmOaa4h5LJMlCHGks5rjrH9gaJpZM4MHkSd> .

[abernix]

LGTM!

[abernix]

Never hurts to ask for another opinion, thanks for the response! And no worries, I've gone ahead and updated it (via GitHub Edit).

Thanks, @domq.