Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Shell: Don't be confused by SyntaxErrors thrown by command execution. #8446
referenced this pull request
Mar 2, 2017
This is awesome! Thanks for looking into this, @mattmccutchen!
Just to provide insight to anyone peering in: Some of this
Re: Tests. I think all regressions are unintentional and I'd like to get tests for this eventually, but seeing at there is not currently a harness in place for the shell (an interactive test is necessary, perhaps) and this is actually an improvement to an existing deficiency, we might be willing to forgo a test for this. That being said, I'll leave this for more "LGTM"s as a precaution.