Allow incorrect `package.json` when determining binary dependencies. #8468
Conversation
We now check `package.json` in order to help make an educated decision as to whether or not a package has binary dependencies which need to be rebuilt. In some cases, such as the `npmconf` npm which is included as a dependency of `flow-router, the `package.json` is invalid (i.e. empty), and we should silently permit this. Fixes #8427
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We now check
package.json(thanks to bcffe53) in order to help make an educated decision as to whether or not a package has binary dependencies which need to be rebuilt. In some cases, such as thenpmconfnpm which is included as a dependency offlow-router, apackage.jsonused as a test fixture exists but is empty. We should silently permit this.Fixes #8427