New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow incorrect `package.json` when determining binary dependencies. #8468

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
2 participants
@abernix
Member

abernix commented Mar 8, 2017

We now check package.json (thanks to bcffe53) in order to help make an educated decision as to whether or not a package has binary dependencies which need to be rebuilt. In some cases, such as the npmconf npm which is included as a dependency of flow-router, a package.json used as a test fixture exists but is empty. We should silently permit this.

Fixes #8427

Allow incorrect `package.json` when determining binary dependencies.
We now check `package.json` in order to help make an educated decision
as to whether or not a package has binary dependencies which need to be
rebuilt.  In some cases, such as the `npmconf` npm which is included
as a dependency of `flow-router, the `package.json` is invalid (i.e.
empty), and we should silently permit this.

Fixes #8427

@abernix abernix added this to the Release 1.4.2.x milestone Mar 8, 2017

@abernix abernix requested a review from benjamn Mar 8, 2017

@benjamn

benjamn approved these changes Mar 8, 2017

lgtm!

@benjamn benjamn merged commit c2c92b9 into devel Mar 8, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abernix abernix modified the milestones: Release 1.4.3.x, Release 1.4.2.x Mar 9, 2017

@abernix abernix deleted the abernix/fix/8427 branch Mar 9, 2017

@abernix abernix modified the milestones: Release 1.4.3.x, Release 1.4.3.2 Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment