Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #770 #866

Closed
wants to merge 2 commits into from
Closed

Fix issue #770 #866

wants to merge 2 commits into from

Conversation

@estark37
Copy link
Contributor

@estark37 estark37 commented Mar 22, 2013

Added a test and a quick fix for the {{#with}} falsy issue, adding an optional else case.

estark37 added 2 commits Mar 22, 2013
Add optional else case to {{#with}}.
@glasser

This comment has been minimized.

Copy link

@glasser glasser commented on packages/handlebars/evaluate.js in 5a4dbb9 Mar 22, 2013

Hmm, interesting, I hadn't considered the Array case, and I'm not really sure why you would ever use an Array with #with (can you do eg {{0}}?) But that's consistent with #if so it makes sense. (So basically, #with is exactly like #if except that it also updates the data context in the true case.)

@glasser
Copy link
Member

@glasser glasser commented Mar 22, 2013

Thanks Emily! Merged to devel.

@glasser glasser closed this Mar 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants