Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Change default `from` email for `accounts-password` to an "example". #8760
Currently, the default "from" address for
The correct way to set the default "from" address is by setting:
Accounts.emailTemplates.from = "Name <email@example.com>";
As per the documentation here:
By changing it to "example.com", and making a more obvious "example"
Currently, the default "from" address for `meteor-accounts` is "firstname.lastname@example.org". While this works for many users, and granted it is a "no reply" address and there should be no expectation of the address working, it contributes to a negative spam rating for the "meteor.com" domain and a surplus of extra e-mail. The correct way to set the default "from" address is by setting: Accounts.emailTemplates.from = "Name <email@example.com>"; As per the documentation here: https://docs.meteor.com/api/passwords.html#Accounts-emailTemplates By changing it to "example.com", and making a more obvious "example" out of the name ("Accounts Example"), it should encourage users to actually change the address to something more reasonable especially since many e-mail providers will also reject mail coming from "example.com", which should provide a clear warning to those who have their e-mail misconfigured.
@abernix could we use an invalid value,
This is not a docs, it's working code.
While the page at example.com says it's for documents, the RFC doesn't make that specific designation and the domain has no MX records – so besides the fact that it's not deliverable, its spam rating doesn't matter. All in all, I think example.com is a safer bet.
As this could be breaking for anyone who hasn't configured
I've verified that an error is thrown by