Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8761 in three different ways. #8765

Merged
merged 2 commits into from
Jun 6, 2017
Merged

Fix #8761 in three different ways. #8765

merged 2 commits into from
Jun 6, 2017

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jun 6, 2017

The root of the problem was that the es5-ext npm package contains directories called #, e.g.
https://github.com/medikoo/es5-ext/tree/master/array/%23

These directory names were being sanitized to '' and thus ignored when reserving paths in the Builder, which led to reservation conflicts later.

This commit fixes the problem in three different and independently sufficient ways:

  • Use files.mkdir_p instead of files.mkdir when creating parent directories of written files.
  • Replace illegal characters in sanitized paths with _ instead of ''.
  • Allow # in sanitized paths (only needs to be escaped in the shell, not actually forbidden in paths).

Fixes #8761.

The root of the problem was that the es5-ext npm package contains
directories called '#', e.g.
https://github.com/medikoo/es5-ext/tree/master/array/%23

These directory names were being sanitized to '' and thus ignored when
reserving paths in the Builder, which led to reservation conflicts later.

This commit fixes the problem in three different and independently
sufficient ways:

* Use files.mkdir_p instead of files.mkdir when creating parent
  directories of written files.

* Replace illegal characters in sanitized paths with '_' instead of ''.

* Allow '#' in sanitized paths (only needs to be escaped in the shell, not
  actually forbidden in paths).
@benjamn benjamn added this to the Release 1.5.1 milestone Jun 6, 2017
@benjamn benjamn self-assigned this Jun 6, 2017
@benjamn benjamn requested review from hwillson and abernix June 6, 2017 14:56
Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like, I get it... but what an interesting directory name! LGTM!

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@benjamn benjamn merged commit cdc047b into devel Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5] Cannot dynamic import slate library.
3 participants