Fix #8761 in three different ways. #8765
Merged
Conversation
The root of the problem was that the es5-ext npm package contains directories called '#', e.g. https://github.com/medikoo/es5-ext/tree/master/array/%23 These directory names were being sanitized to '' and thus ignored when reserving paths in the Builder, which led to reservation conflicts later. This commit fixes the problem in three different and independently sufficient ways: * Use files.mkdir_p instead of files.mkdir when creating parent directories of written files. * Replace illegal characters in sanitized paths with '_' instead of ''. * Allow '#' in sanitized paths (only needs to be escaped in the shell, not actually forbidden in paths).
|
Like, I get it... but what an interesting directory name! LGTM! |
|
Looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The root of the problem was that the
es5-extnpm package contains directories called#, e.g.https://github.com/medikoo/es5-ext/tree/master/array/%23
These directory names were being sanitized to
''and thus ignored when reserving paths in theBuilder, which led to reservation conflicts later.This commit fixes the problem in three different and independently sufficient ways:
files.mkdir_pinstead offiles.mkdirwhen creating parent directories of written files._instead of''.#in sanitized paths (only needs to be escaped in the shell, not actually forbidden in paths).Fixes #8761.