Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8761 in three different ways. #8765

Merged
merged 2 commits into from Jun 6, 2017
Merged

Fix #8761 in three different ways. #8765

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4ee6d
Fix #8761 in three different ways.
benjamn Jun 6, 2017
dedc1ce
Update unicode asset sanitization tests (and History.md).
benjamn Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/isobuild/builder.js
View file
Open in desktop
Expand Up @@ -143,7 +143,7 @@ Previous builder: ${previousBuilder.outputPath}, this builder: ${outputPath}`

if (needToMkdir) {
// It's new -- create it
files.mkdir(files.pathJoin(this.buildPath, partial), 0o755);
files.mkdir_p(files.pathJoin(this.buildPath, partial), 0o755);
}
this.usedAsFile[partial] = false;
} else if (this.usedAsFile[partial]) {
Expand All @@ -169,7 +169,7 @@ Previous builder: ${previousBuilder.outputPath}, this builder: ${outputPath}`
throw new Error(`Path contains forbidden segment '${part}'`);
}

part = part.replace(/[^a-zA-Z0-9._\:\-@]/g, '');
part = part.replace(/[^a-zA-Z0-9._\:\-@#]/g, '_');

// If at last component, pull extension (if any) off of part
let ext = '';
Expand Down Expand Up @@ -345,7 +345,7 @@ Previous builder: ${previousBuilder.outputPath}, this builder: ${outputPath}`
}
}
if (needToMkdir) {
files.mkdir(files.pathJoin(this.buildPath, soFar), 0o755);
files.mkdir_p(files.pathJoin(this.buildPath, soFar), 0o755);
}
this.usedAsFile[soFar] = false;
}
Expand Down