Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoffeeScript to 1.12.6 #8777

Merged
merged 3 commits into from Jun 19, 2017
Merged

Conversation

GeoffreyBooth
Copy link
Contributor

Bumps the CoffeeScript version, and uses the new primary repo, coffeescript.

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GeoffreyBooth - this looks good to me. LGTM!

@GeoffreyBooth
Copy link
Contributor Author

@hwillson Thanks. When will the new package be released?

Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwillson
Copy link
Contributor

I've added a History.md entry and adjusted the package version. As soon as the tests finish running, I'll merge. Thanks!

@abernix abernix added this to the Package Patches milestone Jun 16, 2017
@hwillson
Copy link
Contributor

Well, Travis appears to be hung. The build passed but Travis hasn't relayed those details to GH. I'm looking into it ...

@@ -1,6 +1,6 @@
Package.describe({
summary: "Javascript dialect with fewer braces and semicolons",
version: "1.12.6_1"
version: "1.12.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Don't do that! Please wrap all upstream packages always with _1 and then bump it if needed. It is really confusing if there is 1.12.6 and later on 1.12.6_1. Which one is newer? Hard to know from just looking at the version.

@abernix abernix merged commit a09f5e3 into meteor:devel Jun 19, 2017
@abernix
Copy link
Contributor

abernix commented Jun 19, 2017

Published as coffeescript@1.12.6_1! Thanks!

abernix added a commit that referenced this pull request Jun 19, 2017
As discussed in #8777 it seems best
to always have the suffix on npm-wrapper packages.

If anything, as a reminder when bumping the version on wrapper packages,
but also just to generally make it more clear if a version suffixed with
`_1` is actually higher than a non-suffixed version or not.
@GeoffreyBooth GeoffreyBooth deleted the coffeescript-1.12.6 branch October 14, 2017 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants