Add mongo-dev-server package #8853

zimme · 2017-06-27T22:20:04Z

Only start the MongoDB server if this package is present in the project.

For now I've added mongo-dev-server as a dependency of mongo, do we want to do this?

A lot of packages rely on the meteor package and when using Meteor as a build system you might wanna use packages like static-html or dynamic-import but you might still not want a local mongodb instance started.

I'm thinking we could remove mongo-dev-server as a mongo dependency and use the upgrades thing to just add this package to all current meteor projects on upgrade and add it to the default packages when creating a new project.

The way this PR is now results in MONGO_URL being set to 'no-mongo-server' if mongo-dev-server isn't present and MONGO_URL hasn't been manually set. This will prevent Meteor from trying to connect to a local mongo server even if mongo is present in the project. I don't know if this have any other negative effects.

This is a first step at resolving meteor/meteor-feature-requests#31.

Only start the MongoDB server if this package is present in the project.

zimme · 2017-06-27T22:24:05Z

Turned out that the changes in #8769 was enough for this to work. There was no need to do the same for .meteor/versions to cover this use-case. i.e. --extra-packages mongo-dev-server/mongo will trigger the starting of mongodb.

zimme · 2017-06-28T14:27:19Z

I'll have a look at the self tests, some might fail if they expect MongoDB without adding mongo.

hwillson

Thanks @zimme, this looks great! I've added a few small review comments, but I'll take another look after the tests are passing. Thanks again!

hwillson · 2017-07-10T16:46:19Z

packages/mongo-dev-server/README.md

+# mongo-dev-server
+[Source code of released version](https://github.com/meteor/meteor/tree/master/packages/mongo-dev-server) | [Source code of development version](https://github.com/meteor/meteor/tree/devel/packages/mongo-dev-server)
+***
+


Would you mind adding one or two sentences describing the package in the README?

I can do this.

hwillson · 2017-07-10T16:50:24Z

packages/mongo-dev-server/package.js

+});
+
+Package.onUse(function (api) {
+  api.addFiles('info.js', 'server');


Maybe consider using api.mainModule here instead?

I'll have a look.

hwillson · 2017-07-10T16:54:27Z

packages/mongo/package.js

@@ -34,7 +34,8 @@ Package.onUse(function (api) {
    'diff-sequence',
    'mongo-id',
    'check',
-    'ecmascript'
+    'ecmascript',
+    'mongo-dev-server',


Relating to your comment:

I'm thinking we could remove mongo-dev-server as a mongo dependency and use the upgrades thing to just add this package to all current meteor projects on upgrade and add it to the default packages when creating a new project.

I like this idea - Not forcing mongo-dev-server as a dependency, and using an upgrader instead, gets my vote!

I think I'd need help with how to add this to the upgrader instead.

Sure thing - I haven't had to build one myself, but as far as I understand things, you'll be looking to add your changes in tools/upgraders.js. The process seems to be pretty well documented in that file - you'll be adding a new upgrade name / section, and you can test things out by running meteor admin run-upgrader myupgradername. The 1.5-add-dynamic-import-package upgrader section in that file might be a good one to copy / start from.

hwillson · 2017-07-10T16:56:59Z

tools/runners/run-all.js

+    });
+
+    const packageMap = self.projectContext.packageMap;
+    const hasMongoDevServerPackage = packageMap && packageMap.getInfo('mongo-dev-server') != null;


Would you mind switching to use !== just to make sure we're matching the rest of the source.

I used != to match both null and undefined. But if getInfo always returns null when not found then it shouldn't be a problem using !==.

Thanks @zimme, it's probably okay to leave it then. I personally prefer to not use lenient equality / non-equality checks on null / undefined, as when going back over old code I always end up questioning whether the leniency was intended or not ... 🙂.

benjamn

After talking about this in the issue triage club (including @hwillson), the team is comfortable with the dependency on the dev-only mongo-dev-server package, rather than some other approach like an upgrader.

zimme · 2017-07-12T20:30:25Z

Just wanted to give you guys a heads up, I'm heading off on vacation this Friday for 2 weeks and I don't think I'll have time to finish this up before that.

hwillson · 2017-07-13T01:32:37Z

Nooo, you can't leave!! Seriously though, no problem at all @zimme - thanks for getting things this far. I'll aim to make the remaining small changes, over the next few days (schedule permitting of course - you might find this PR waiting for you when you get back 😉). Have a great 🏖 !

…artup.

hwillson · 2017-07-22T14:47:58Z

We should be all set here now - LGTM!

abernix · 2017-07-26T15:08:07Z

LGTM, thanks!

* Add mongo-dev-server package Only start the MongoDB server if this package is present in the project. * Small layout/formatting adjustments; updated README. * Allow tests using fake-mongod to start (fake) Mongo. * Adjust test stdout matching to be less sensitive to ordering. * Add `mongo-dev-server` History.md entry. * Remove mongo start check since the tested for error prevents mongo startup. * Remove README traling whitespace. * Bump mongo package version.

@zimme

This reverts commit 4d37a05. After git bisecting between origin/release-1.5 and origin/release-1.5.2, I identified this commit as the culprit in recent failures of the modules test app: https://circleci.com/gh/meteor/meteor/4857#tests/containers/3 Note that the modules test app seems to be failing only on Linux, and it does pass reliably with this commit reverted. It must have something to do with Mongo failing to start, and thus the "App running at" message never appears, but I don't have a good theory why that might be. The command to run just the modules test app is meteor self-test --history 1000 'modules - test app' @zimme @hwillson @abernix any ideas?

Only start the MongoDB server if this package is present in the project. This reverts commit 565281e.

Add mongo-dev-server package

5ca3db7

Only start the MongoDB server if this package is present in the project.

zimme mentioned this pull request Jun 28, 2017

Provide a better way to use the Meteor Tool without Mongo meteor/meteor-feature-requests#31

Open

zimme changed the title ~~Add mongo-dev-server package~~ [Work in progress] Add mongo-dev-server package Jul 2, 2017

hwillson suggested changes Jul 10, 2017

View reviewed changes

benjamn reviewed Jul 12, 2017

View reviewed changes

hwillson added 3 commits July 18, 2017 10:23

Small layout/formatting adjustments; updated README.

f51368a

Allow tests using fake-mongod to start (fake) Mongo.

581abda

Adjust test stdout matching to be less sensitive to ordering.

7203e03

hwillson approved these changes Jul 18, 2017

View reviewed changes

hwillson added 3 commits July 18, 2017 20:45

Merge devel to make sure we have the latest History.md, before updating.

d4b8586

Add mongo-dev-server History.md entry.

026dd16

Remove mongo start check since the tested for error prevents mongo st…

1a0130b

…artup.

benjamn added this to the Release 1.5.2 milestone Jul 19, 2017

hwillson added 4 commits July 19, 2017 15:31

Merge branch 'devel' into zimme/mongo-dev-server

0f3eb9e

Remove README traling whitespace.

bef9624

Merge devel in to pull in latest self-test timeout fixes.

8d1d9a2

Bump mongo package version.

bfdcee5

abernix merged commit 4d37a05 into meteor:devel Jul 26, 2017

hwillson added a commit to hwillson/meteor that referenced this pull request Aug 9, 2017

Add mongo-dev-server package (meteor#8853)

2e11c47

Only start the MongoDB server if this package is present in the project. This reverts commit 565281e.

benjamn pushed a commit that referenced this pull request Aug 10, 2017

Reinstate the mongo-dev-server package (#8853) (#8999)

956d8db

zimme deleted the zimme/mongo-dev-server branch September 5, 2017 17:55

zimme changed the title ~~[Work in progress] Add mongo-dev-server package~~ Add mongo-dev-server package Sep 5, 2017

Add mongo-dev-server package #8853

Add mongo-dev-server package #8853

zimme commented Jun 27, 2017 •

edited

zimme commented Jun 27, 2017 •

edited

zimme commented Jun 28, 2017

hwillson left a comment

hwillson Jul 10, 2017

zimme Jul 10, 2017

hwillson Jul 10, 2017

zimme Jul 10, 2017

hwillson Jul 10, 2017

zimme Jul 10, 2017

hwillson Jul 10, 2017

hwillson Jul 10, 2017

zimme Jul 10, 2017 •

edited

hwillson Jul 10, 2017

benjamn left a comment

zimme commented Jul 12, 2017 •

edited

hwillson commented Jul 13, 2017

hwillson commented Jul 22, 2017

abernix commented Jul 26, 2017

Add mongo-dev-server package #8853

Add mongo-dev-server package #8853

Conversation

zimme commented Jun 27, 2017 • edited

zimme commented Jun 27, 2017 • edited

zimme commented Jun 28, 2017

hwillson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zimme Jul 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjamn left a comment

Choose a reason for hiding this comment

zimme commented Jul 12, 2017 • edited

hwillson commented Jul 13, 2017

hwillson commented Jul 22, 2017

abernix commented Jul 26, 2017

zimme commented Jun 27, 2017 •

edited

zimme commented Jun 27, 2017 •

edited

zimme Jul 10, 2017 •

edited

zimme commented Jul 12, 2017 •

edited