New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Node.js and npm version in the `star.json` manifest. #8956

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@abernix
Member

abernix commented Jul 28, 2017

This makes it possible to know exactly which version of Node.js and npm were used by the meteor tool which the bundle was built from by making new values available alongside the existing meteorRelease value in star.json: nodeVersion and npmVersion. The version of the star.json has remained the same since this is only adding new properties, not removing any existing. This preserves the existing .node_version.txt for compatibility reasons, but it's reasonable to believe that may be deprecated in a future version.

Those using .node_version.txt should consider using the nodeVersion value in star.json, though it should be noted that it does not include the v(ersion) prefix as the .node_version.txt file did.

Include the Node.js and npm version in the `star.json` manifest.
This makes it possible to know exactly which version of Node.js and npm
were used by the `meteor` command from which the bundle was built from.
@abernix

This comment has been minimized.

Member

abernix commented Jul 28, 2017

I'll add a History.md entry, after this passes CI.

@abernix abernix requested a review from benjamn Jul 28, 2017

@abernix abernix added this to the Release 1.5.2 milestone Aug 1, 2017

@@ -14,6 +14,7 @@ var buildmessage = require('../utils/buildmessage.js');
var utils = require('../utils/utils.js');
var runLog = require('../runners/run-log.js');
var Profile = require('../tool-env/profile.js').Profile;
import { version as npmVersion } from 'npm';

This comment has been minimized.

@benjamn

benjamn Aug 2, 2017

Member

This can be export { version as npmVersion } from "npm", and then you don't need to export it below!

This comment has been minimized.

@abernix

abernix Aug 2, 2017

Member

I do prefer this syntax! But opted for this technique to make the meteorNpm API feel more whole (as in, it seemed like the meteorNpm api should have a npmVersion exposed).

@benjamn benjamn dismissed their stale review Aug 2, 2017

Not super important, on second thought.

@benjamn benjamn merged commit 4665f2a into devel Aug 2, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abernix abernix deleted the abernix/add-node-and-npm-to-star.json branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment