/meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support env in babelrc #8963

Merged
merged 3 commits into from Aug 7, 2017

Conversation

Reviewers

@hwillson hwillson

@benjamn benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  Release 1.5.2
4 participants
@hexsprite @meteor-bot @benjamn @hwillson
@hexsprite
Contributor

hexsprite commented Jul 29, 2017

This PR implements support for the env key in .babelrc files.

It looks first for BABEL_ENV then NODE_ENV then finally defaults to development per the Babel documented behavior.

Rationale: be able to add additional babel plugins/presets for testing environment for example (eg. babel-plugin-istanbul)

I wasn't sure where to add tests as I did not see any existing tests for the functionality. Please let me know your feedback.
@hexsprite
support env in babelrc
Loading status checks…
0fe023e
@meteor-bot

This comment has been minimized.

Sign in to view

meteor-bot commented Jul 29, 2017

@hexsprite: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@hexsprite hexsprite referenced this pull request Jul 29, 2017

Open

Ignoring environment variables in the babelrc #14

@benjamn benjamn added this to the Release 1.5.2 milestone Jul 29, 2017

@benjamn

benjamn requested changes Aug 2, 2017
View changes

packages/babel-compiler/babel-compiler.js Outdated
@@ -300,6 +300,16 @@ BCp._inferHelper = function (
merge(babelOptions, babelrc, "presets");
merge(babelOptions, babelrc, "plugins");
const babelEnv = (process.env.BABEL_ENV ||
process.env_NODE_ENV ||

This comment has been minimized.

Sign in to view
Copy link
@benjamn

benjamn Aug 2, 2017

Member

Should this be process.env.NODE_ENV?

This comment has been minimized.

Sign in to view
Copy link
@hexsprite

hexsprite Aug 2, 2017

Contributor

I believe so. From the babel docs:

The env key will be taken from process.env.BABEL_ENV, when this is not available then it uses process.env.NODE_ENV if even that is not available then it defaults to "development".

https://babeljs.io/docs/usage/babelrc/#env-option

This comment has been minimized.

Sign in to view
Copy link
@hwillson

hwillson Aug 2, 2017

Member

@hexsprite Ben's referring to the typo in your process.env_NODE_ENV reference (note the _).

This comment has been minimized.

Sign in to view
Copy link
@hexsprite

hexsprite Aug 2, 2017

Contributor

Oh, woops. Got it.
@benjamn

This comment has been minimized.

Sign in to view
Member

benjamn commented Aug 2, 2017

I wasn't sure where to add tests as I did not see any existing tests for the functionality. Please let me know your feedback.

I would recommend adding env to some of the .babelrc files in the modules test app, or creating new local packages with new .babelrc files in that app.

hexsprite added some commits Aug 4, 2017

@hexsprite
fix typo
Loading status checks…
3ad83de
@hexsprite
added test for babel-env
Loading status checks…
1e7cefa
@benjamn

benjamn approved these changes Aug 7, 2017
View changes

@benjamn benjamn changed the base branch from devel to release-1.5.2 Aug 7, 2017

@benjamn benjamn merged commit 77ecbab into meteor:release-1.5.2 Aug 7, 2017
2 of 3 checks passed

2 of 3 checks passed

ci/circleci Your tests failed on CircleCI
Details
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

benjamn added a commit that referenced this pull request Aug 7, 2017

@benjamn
Enable transform-do-expressions in production for modules test app. 
The modules test app appears to be running with process.env.NODE_ENV equal
to "production" on Circle CI: https://circleci.com/gh/meteor/meteor/5030.

Enabling this transform in production as well as development is fine
because we primarily want to test that plugins from the "env" section of
.babelrc are respected, regardless of the value of process.env.NODE_ENV.
Using different plugins in production might be worth testing, too, but
that's less critical.

Follow-up to #8963.
Verified
This commit was signed with a verified signature.
@benjamn benjamn Ben Newman
GPG key ID: 15D2E57778C1A4BF Learn about signing commits
Loading status checks…
6de5c25

@hwillson hwillson referenced this pull request Aug 10, 2017

Merged

Reinstate the mongo-dev-server package (#8853) #8999

benjamn added a commit that referenced this pull request Sep 26, 2017

@benjamn
Bump ecmascript patch version to republish compile-ecmascript plugin. 
When the ecmascript package version was last bumped in
18e4c17, it appears that
babel-compiler@6.20.0 had not yet been published, so ecmascript was
published with a copy of that compiler plugin that did not support the
"env" property of .babelrc files (#8963).

Bumping again and republishing in hopes of fixing that problem.
Verified
This commit was signed with a verified signature.
@benjamn benjamn Ben Newman
GPG key ID: 15D2E57778C1A4BF Learn about signing commits
Loading status checks…
369afe7

@steventebrinke steventebrinke referenced this pull request Sep 28, 2017

Closed

Babel compiler caches too aggressively (without considering NODE_ENV) #9145

@RobertLowe RobertLowe referenced this pull request Jun 2, 2018

Open

Meteor packages don't play well with babel code coverage plugins #9931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment