Visually notify of uncaught exceptions breaking client tests #9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a global `window.onerror` event handler to the `test-in-browser` package, to catch any previously uncaught exceptions. When uncaught exceptions are found, an alert box is displayed above the test results table. This should help notify developers of hidden uncaught exceptions that could be preventing client tests from running. Fixes meteor#4979.
benjamn
approved these changes
Aug 22, 2017
|
Oh wow, this is awesome! |
benjamn
reviewed
Aug 22, 2017
| @@ -5,6 +5,7 @@ Package.describe({ | |||
| }); | |||
There was a problem hiding this comment.
Do we need to bump the test-in-browser package version?
There was a problem hiding this comment.
Oops - good catch. Yes, we should - I've bumped it to 1.0.14. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to help fix #4979. I know external package
Tinytestuse has dwindled since adding--driver-packagesupport tometeor test-packages, but since we are still supporting it (and it's used by the Meteor core), we might as well improve thetest-in-browserUI experience a bit (let me know if anyone disagrees!).These changes add a global
window.onerrorevent handler to thetest-in-browserpackage, to catch any previously uncaught exceptions. When uncaught exceptions are found, an alert like the following is shown at the top of thetest-in-browserUI:This should help notify developers of potential errors behind the scenes, that are preventing the client side tests from running.
(P.S. --> I snuck
ecmascriptin there ... hope that's okay!)