Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate fastclick #9039

Merged
merged 2 commits into from Sep 4, 2017
Merged

Deprecate fastclick #9039

merged 2 commits into from Sep 4, 2017

Conversation

hwillson
Copy link
Contributor

This PR's History.md entry should explain the reasoning behind this PR, so I'll just copy it verbatim:

* The `fastclick` package (previously included by default in Cordova
  applications through the `mobile-experience` package) has been deprecated.
  This package is no longer maintained and has years of outstanding
  unresolved issues, some of which are impacting Meteor users. Most modern
  mobile web browsers have removed the 300ms tap delay that `fastclick` worked
  around, as long as the following `<head />` `meta` element is set (which
  is generally considered a mobile best practice regardless, and which the
  Meteor boilerplate generator already sets by default for Cordova apps):
  `<meta name="viewport" content="width=device-width">`
  If anyone is still interested in using `fastclick` with their application,
  it can be installed from npm directly (`meteor npm install --save fastclick`).
  Reference:
  [Mobile Chrome](https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away)
  [Mobile Safari](https://bugs.webkit.org/show_bug.cgi?id=150604)

Fixes #6286 (and likely others). Thanks!

@hwillson
Deprecate fastclick
a365ad7 
Since `fastclick` is no longer maintained, is introducing bugs,
and is no longer really necessary with modern mobile browsers,
it is being deprecated.
@hwillson
Add fastclick deprecation PR link, now that is exists
3067c63
abernix
abernix approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @hwillson!

@abernix abernix added this to the Release 1.6 milestone Aug 28, 2017
@abernix abernix merged commit b97f2f9 into meteor:devel Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abernix abernix abernix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6
Development

Successfully merging this pull request may close these issues.

1.3 beta Cordova iOS fastclick problem with contenteditable=“true”
2 participants
@hwillson @abernix