added onUserUpdate hook

[gerwinbrunner]

I found a missing feature documented in the code here:
https://github.com/meteor/meteor/blob/master/packages/accounts-base/accounts_server.js#L1433

So I just implemend it in the way the onCreateUser hook was done.

[apollo-cla]

@gerwinbrunner: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[sebakerckhof]

It's weird to me that onCreateUser would be called for every created user, while onUpdateUser would only be called for users logging in via oAuth. If this is a useful feature, I'd at least give it a more descriptive name along the lines of 'onExternalLogin`

[merlinstardust]

I agree that it should probably be called onExternalLogin to be more clear. But I'm not sure what benefit this provides. There isn't a way to pass options through to the user doc like you can with onCreateUser.

onCreateUser allows you to pass options in via Accounts.createUser(options). But, as far as I can tell, Meteor.loginWith<ExternalService> has no means to pass options to this new function onExternalLogin. And these should share the same features

[gerwinbrunner]

@sebakerckhof Thanks for the input... I just went with what was in the comments of the original code. I'll change the name.

@merlinpatt The purpose for this is to be able to update profile (or other data) after an OAuth login.
That information is passed by the OAuth service. An example would be to change the users country of residence if he changed that info in the original OAuth service.

[hwillson]

Thanks for working on this @gerwinbrunner! I've added a few minor style comments to this review. Other than those, I think we should get some tests in place for these changes. Would you mind adding tests for this? See the accounts - updateOrCreateUserFromExternalService - Facebook test for a related example. Thanks again!

[hwillson]

Can you adjust this so there is only one blank line before and after the onExternalLogin function?

[hwillson]

This comment needs to change since we're now providing a way to process options. Please remove the XXX line, and consider updating this comment to better reflect the new functionality. Actually, you could consider just removing this comment entirely - now that we're addressing options, the code here pretty much speaks for itself.

[hwillson]

Hi @gerwinbrunner - just touching base on this. Have you had a chance to review my comments?

[gerwinbrunner]

Sorry, having pretty busy the last week. I will look into it this week and update the PR. Hugh Willson wrote:

…

Hi @gerwinbrunner <https://github.com/gerwinbrunner> - just touching base on this. Have you had a chance to review my comments? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9042 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEm7uFwYvH501cdtin6FX2Y5NraMMvqks5sjpjjgaJpZM4PBnnE>.

[hwillson]

@gerwinbrunner Have you had a chance to look at this again? Let us know if you'll have some time to wrap this up. Thanks!

I've made the requested changes, so they should be reviewed by someone else.

[hwillson]

All outstanding items here should now be addressed, so this is ready for a final review.

[benjamn]

Rebased and pushed to devel as 20f698a

[fgm]

AFAICS this actually closes #7213 from 06/2016, and its followup meteor/meteor-feature-requests#68

[hwillson]

Good catch - thanks @fgm!