Make sure Accounts login only sets 1 onReconnect callback #9148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes added in meteor@d854a4b fixed a long standing issue where the Accounts system was overwriting other DDP `connection.onReconnect` callbacks, that were potentially set by developers (and vice-versa - developers could overwrite the `onReconnect` callback registered by the Accounts system, which impacted logging back in after reconnecting). Unfortunately these changes are also registering a new duplicate `onReconnect` callback to be called, after every login. These duplicate callbacks pile up and are all called when reconnecting, which eventually breaks user logins. The changes in this commit make sure that any previously set Accounts login `onReconnect` callback is first removed, before adding a new callback. This ensures the Accounts system is only ever setting one `onReconnect` callback after logging in. Fixes meteor#9140.
abernix
referenced
this pull request
Sep 28, 2017
* Fix bug #5665: add DDP.onReconnect(), deprecate conn.onReconnect Deprecate use of `connection.onReconnect = func`. Instead, a new `DDP.onReconnect(callback)` method should be used to register callbacks to call when a connection reconnects. The connection that is reconnecting is passed as the only argument to `callback`. This is used by the accounts system to relogin on reconnects without interfering with other code which uses `connection.onReconnect`. * Adjust History entry, package versions, code cleanup
|
Merged into |
|
Just confirming that the tests for the merge commit (01b5487) and passed ✅: https://circleci.com/workflow-run/25eda4df-3993-4611-91fa-4e7f51d2b9c5. Thanks so much for the fix and amended test, @hwillson! |
|
A release candidate for Meteor 1.5.2.2 has been released which includes this change. Please help test it and confirm whether this issue is fixed! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes added in d854a4b fixed a long standing issue where the Accounts system was overwriting other DDP
connection.onReconnectcallbacks, that were potentially set by developers (and vice-versa - developers could overwrite theonReconnectcallback registered by the Accounts system, which impacted logging back in after reconnecting). Unfortunately these changes are also registering a new duplicateonReconnectcallback to be called, after every login. These duplicate callbacks pile up and are all called when reconnecting, which eventually breaks user logins.The changes in this commit make sure that any previously set Accounts login
onReconnectcallback is first removed, before adding a new callback. This ensures the Accounts system is only ever setting oneonReconnectcallback after logging in.Fixes #9140.