New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS icon and launch screen sizes for iOS 11 #9198

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
4 participants
@skirunman
Contributor

skirunman commented Oct 9, 2017

Fixes #9196
See Apple app icon sizes and launch screen sizes.

I also added some comments to documentation for mobile configuration so a user can understand what devices the icons and launch screens relate to, but not sure if this will build correctly or if you think it is a good idea.

@benjamn benjamn changed the base branch from devel to release-1.6 Oct 10, 2017

@benjamn benjamn changed the base branch from release-1.6 to devel Oct 10, 2017

@benjamn benjamn merged commit 8279f12 into meteor:devel Oct 10, 2017

11 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjamn

This comment has been minimized.

Member

benjamn commented Oct 10, 2017

Thanks @skirunman (and @markoshust)!

@benjamn benjamn added this to the Release 1.5.3 milestone Oct 10, 2017

@skirunman skirunman deleted the skirunman:patch-1 branch Oct 10, 2017

@AndyNormore

This comment has been minimized.

AndyNormore commented Oct 12, 2017

A bunch of us coming over to say thank you! This is a solid fix.

benjamn added a commit that referenced this pull request Oct 14, 2017

Update History.md for PR #9198 (#9227)
Removed this change from #9213 as it goes with #9198

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Oct 15, 2017

Merged

Update upstream #84

@andyrichardson

This comment has been minimized.

andyrichardson commented Oct 17, 2017

Thanks for fixing this. Looking forward to it being pushed to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment