New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support object-valued "browser" field in package.json. #9311

Merged
merged 11 commits into from Nov 6, 2017

Conversation

Projects
None yet
1 participant
@benjamn
Member

benjamn commented Nov 6, 2017

This PR implements support for the "relative style" of browser replacements, as discussed in my comment here: #6890 (comment)

Replacements that use the "package style" are simply ignored, due to the prohibitive cost of supporting that style at runtime. There seemed to be a consensus in the #6890 discussion that partially supporting object-valued browser fields was better than not supporting them at all.

benjamn added some commits Sep 11, 2017

Refactor Resolver handling of package.json files.
Any package.json file that includes an object-valued "browser" field will
now be included in the .packageJsonMap.
Rename installPath property to absModuleId, and make absolute.
The `installPath` property was always essentially an absolute module
identifier that was simply missing the leading '/' character, so this
commit acknowledges that role by renaming the property to `absModuleId`
and adding the leading slash.

@benjamn benjamn added this to the Release 1.6.1 milestone Nov 6, 2017

@benjamn benjamn self-assigned this Nov 6, 2017

@benjamn benjamn merged commit d357116 into devel Nov 6, 2017

14 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment