New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone X status bar fix #9375

Merged
merged 5 commits into from Nov 22, 2017

Conversation

Projects
None yet
3 participants
@skirunman
Contributor

skirunman commented Nov 16, 2017

Fixes #9041

There are number of issues with correctly displaying the status bar on iPhone X as well as correctly showing splash screens. I also documented how to use launch story board images, which is also a key part of the solution for displaying the splash screen on the entire iPhone X display, see meteor/guide@f81c587. However this also requires <meta name="viewport" viewport-fit=cover"> as per various Cordova and Apple technical sites. I have tested this change on iPhone X and iPhone 6 with iOS 11 as well as a number of simulators with different combinations, but needs more testing.

skirunman added some commits Nov 16, 2017

@skirunman skirunman changed the title from Iphone x statusbar to iPhone X status bar fix Nov 16, 2017

@benjamn benjamn modified the milestones: Release 1.5.4, Release 1.6.1 Nov 22, 2017

benjamn added some commits Nov 22, 2017

@benjamn benjamn merged commit 1d5bf0f into meteor:devel Nov 22, 2017

1 of 3 checks passed

ci/circleci: Get Ready CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Author has signed the Meteor CLA.
Details

@skirunman skirunman deleted the skirunman:iphoneX-statusbar branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment