New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mongo 3.4 for 64-bit platforms. #9396

Merged
merged 4 commits into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@abernix
Member

abernix commented Nov 20, 2017

Most of the work to prepare for this change was done through the
excellent work of @hwillson in #9173 which, after some
re-working to support the 64-bit architecture on Windows platforms,
landed in #9218, making this change as simple as bumping
the minor version number (and rebuilding the dev bundle).

From this point forward, and due to Mongo's discontinuation of 32-bit
support in newer versions of MongoDB, 64-bit platforms will, in
development, use newer versions of Mongo while 32-bit architectures
will remain at 3.2.x versions.

Of course, in production, apps are free to use whichever version of
Mongo they would like, provided that version is supported by the
Node Mongo driver and Meteor's Mongo data packages. At this time
there is no target for when Meteor will stop supporting Mongo 3.2,
but developers are encouraged to take steps to upgrade their Mongo
deployments (through their database providers) to newer versions
since Mongo has set September 2018 as the "End-of-Life" for Mongo
3.2.x. For more information on Mongo support cycles, see their
support documents at https://www.mongodb.com/support-policy.

Refs: #9173
Refs: #9218

abernix added a commit that referenced this pull request Nov 20, 2017

@abernix

This comment has been minimized.

Member

abernix commented Nov 20, 2017

Test/CI failures are due to babel/babel#6824.

tl;dr: Babel published a babel@7.0.0-bridge.0 package, which takes npm version precedence over the babel@7.0.0-beta.0 we're relying on (yes, as in, "beta" < "bridge", alphabetically).

Error: Cannot find module '@babel/core'

benjamn added a commit to meteor/babel that referenced this pull request Nov 20, 2017

abernix added some commits Nov 20, 2017

Use Mongo 3.4 for 64-bit platforms.
Most of the work to prepare for this change was done through the
excellent work of @hwillson in #9173 which, after some
re-working to support the 64-bit architecture on Windows platforms,
landed in #9218, making this change as simple as bumping
the minor version number (and rebuilding the dev bundle).

From this point forward, and due to Mongo's discontinuation of 32-bit
support in newer versions of MongoDB, 64-bit platforms will, in
development, use newer versions of Mongo while 32-bit architectures
will remain at 3.2.x versions.

Of course, in production, apps are free to use whichever version of
Mongo they would like, provided that version is supported by the
Node Mongo driver and Meteor's Mongo data packages.  At this time
there is no target for when Meteor will stop supporting Mongo 3.2,
but developers are encouraged to take steps to upgrade their Mongo
deployments (through their database providers) to newer versions
since Mongo has set September 2018 as the "End-of-Life" for Mongo
3.2.x.  For more information on Mongo support cycles, see their
support documents at https://www.mongodb.com/support-policy.

Refs: #9173
Refs: #9218

@abernix abernix force-pushed the abernix/mongo-3.4 branch from d210e08 to 965bb21 Nov 21, 2017

@abernix

This comment has been minimized.

Member

abernix commented Nov 21, 2017

@benjamn I'm likely jumping the gun by assuming meteor-babel@7.0.0-beta.3-2 was ready, but if it's any proof that the change you made in that version via meteor/babel@ac6f3be worked, I rebuilt the dev bundle in this PR with that version bump (109b111) and it is now passing.

@benjamn

This comment has been minimized.

Member

benjamn commented Nov 21, 2017

@abernix My only hesitation about that version of meteor-babel is that tests aren't really passing in Node 4, but that doesn't really matter I suppose.

@abernix abernix force-pushed the abernix/mongo-3.4 branch from 965bb21 to 109b111 Nov 22, 2017

@abernix

This comment has been minimized.

Member

abernix commented Nov 22, 2017

Since I've intentionally force pushed this PR to exclude the (test) dev bundle bump version, this will now fail again, but the previous result was a success so I'll merge this to devel, and rebuild the dev bundle (with a non-test version) on devel.

@abernix abernix merged commit 8433778 into devel Nov 22, 2017

1 of 5 checks passed

ci/circleci: Get Ready Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
CLA Author has signed the Meteor CLA.
Details

@abernix abernix deleted the abernix/mongo-3.4 branch Nov 22, 2017

abernix added a commit that referenced this pull request Nov 22, 2017

Bump $BUNDLE_VERSION to 8.8.3 before rebuilding dev bundle.
In this case, to get the MongoDB 3.4 changes included in #9396.

I'm skipping 8.8.2 since it seems to have been started, but is now unused:

https://github.com/meteor/meteor/commits/dev-bundle-8.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment