Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize tinytest by using ecmascript. #9409

Merged
merged 6 commits into from Nov 23, 2017
Merged

Modernize tinytest by using ecmascript. #9409

merged 6 commits into from Nov 23, 2017

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Nov 22, 2017

This is fairly standard stuff by now, though I'd also like to support returning Promises from test functions.

@benjamn benjamn added this to the Package Patches milestone Nov 22, 2017
@benjamn benjamn self-assigned this Nov 22, 2017
Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @benjamn!

I'd also like to support returning Promises from test functions.

Yes please!


const result = this.func(results, resolve);
if (result && typeof result.then === "function") {
result.then(resolve);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be result.then(resolve, reject), my bad.

@benjamn benjamn merged commit a8cf9c0 into devel Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants