Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upModernize tinytest by using ecmascript. #9409
Conversation
benjamn
added this to the Package Patches milestone
Nov 22, 2017
benjamn
self-assigned this
Nov 22, 2017
benjamn
added some commits
Nov 23, 2017
benjamn
force-pushed the
modernize-tinytest
branch
from
4713c08
to
45e396d
Nov 23, 2017
packages/tinytest/tinytest.js
Outdated
| const result = this.func(results, resolve); | ||
| if (result && typeof result.then === "function") { | ||
| result.then(resolve); |
This comment has been minimized.
This comment has been minimized.
benjamn
merged commit a8cf9c0
into
devel
Nov 23, 2017
13 checks passed
CLA
Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready
Your tests passed on CircleCI!
Details
ci/circleci: Group 0
Your tests passed on CircleCI!
Details
ci/circleci: Group 1
Your tests passed on CircleCI!
Details
ci/circleci: Group 2
Your tests passed on CircleCI!
Details
ci/circleci: Group 3
Your tests passed on CircleCI!
Details
ci/circleci: Group 4
Your tests passed on CircleCI!
Details
ci/circleci: Group 5
Your tests passed on CircleCI!
Details
ci/circleci: Group 6
Your tests passed on CircleCI!
Details
ci/circleci: Group 7
Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
benjamn commentedNov 22, 2017
This is fairly standard stuff by now, though I'd also like to support returning
Promises from test functions.