Modernize tinytest by using ecmascript. #9409
Merged
Conversation
packages/tinytest/tinytest.js
Outdated
|
||
const result = this.func(results, resolve); | ||
if (result && typeof result.then === "function") { | ||
result.then(resolve); |
benjamn
Nov 23, 2017
Author
Member
This should be result.then(resolve, reject)
, my bad.
This should be result.then(resolve, reject)
, my bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is fairly standard stuff by now, though I'd also like to support returning
Promise
s from test functions.