Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize tinytest by using ecmascript. #9409

Merged
merged 6 commits into from Nov 23, 2017
Merged

Modernize tinytest by using ecmascript. #9409

merged 6 commits into from Nov 23, 2017

Conversation

@benjamn
Copy link
Member

@benjamn benjamn commented Nov 22, 2017

This is fairly standard stuff by now, though I'd also like to support returning Promises from test functions.

@benjamn benjamn added this to the Package Patches milestone Nov 22, 2017
@benjamn benjamn self-assigned this Nov 22, 2017
Copy link
Member

@hwillson hwillson left a comment

Looks great @benjamn!

I'd also like to support returning Promises from test functions.

Yes please!

benjamn added 3 commits Nov 23, 2017
@benjamn benjamn force-pushed the modernize-tinytest branch to 45e396d Nov 23, 2017
@benjamn benjamn mentioned this pull request Nov 23, 2017
5 of 6 tasks complete

const result = this.func(results, resolve);
if (result && typeof result.then === "function") {
result.then(resolve);

This comment has been minimized.

@benjamn

benjamn Nov 23, 2017
Author Member

This should be result.then(resolve, reject), my bad.

@benjamn benjamn merged commit a8cf9c0 into devel Nov 23, 2017
13 checks passed
13 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants