Stop serving the application manifest from /manifest.json #9424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6674, Meteor currently serves its own manifest file from
/manifest.json
. This location is not application configurable, and can conflict with other non-Meteor defined manifest files, that are already being served from this location. For example, Google's progressive web app documentation suggests using the/manifest.json
location for its manifest. The newest version of the web app manifest spec recommends using a different location for the web app manifest, likebut the
/manifest.json
location was recommended at one point. Regardless, there isn't really any reason why Meteor needs to use the/manifest.json
location, so let's move it elsewhere.This PR moves moves
/manifest.json
to/__meteor__/webapp/manifest.json
.A few extra notes:
It's worth noting that Meteor core doesn't appear to rely on or use the served
/manifest.json
file in any way. We could consider removing it, but as discussed in [1.3] webapp appears to force-serve manifest.json #6674, there are a few ways in which applications can leverage this information. Since we're already serving it up this PR assumes we're going to keep it, but let me know if you think we should drop it instead.At some point we might want to consider serving all application metadata via a similar
/__meteor__/[package name]/[file]
endpoint. Thebundle-visualizer
is using_meteor/[package name]/stats
for example - at some point we might want to consolidate this. For now though this PR is just addressing the issue raised in [1.3] webapp appears to force-serve manifest.json #6674 directly.Fixes #6674.
Thanks!