Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cordova iOS v4.5.4 #9448

Merged
merged 3 commits into from Dec 12, 2017
Merged

Update to Cordova iOS v4.5.4 #9448

merged 3 commits into from Dec 12, 2017

Conversation

@skirunman
Copy link
Contributor

@skirunman skirunman commented Dec 7, 2017

Update to Cordova iOS v4.5.4 to fix iPhone X splash screen issue.
Fixes #9447

skirunman added 2 commits Dec 7, 2017
Update to Cordova iOS v4.5.4 to fix iPhone X splash screen issue.
Fixes #9447
Copy link
Member

@hwillson hwillson left a comment

Awesome @skirunman - thanks very much - LGTM!

@abernix
Copy link
Member

@abernix abernix commented Dec 12, 2017

@skirunman
Copy link
Contributor Author

@skirunman skirunman commented Dec 12, 2017

@abernix My understanding is that Apple/Xcode, and therefore ios-cordova, does not, and likely will not, support iPad Pro launch screens as static image sizes. Instead, you need to use Xcode storyboard images.

Therefore, I actually think we should remove those commented out iPad Pro sizes. I can do it in this PR if you want or just do it yourself.

The current believe, per @skirunman (whose perspective on the matter I trust), is that these sizes won't be supported in this manner by Apple, but rather as storyboards.

Ref: #9448 (comment)
Copy link
Member

@abernix abernix left a comment

LGTM. We should probably get this into 1.6.1. Thanks, @skirunman.

@abernix abernix added this to the Release 1.6.1 milestone Dec 12, 2017
@abernix abernix merged commit ae3c05c into meteor:devel Dec 12, 2017
12 checks passed
12 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants