Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cordova iOS v4.5.4 #9448

Merged
merged 3 commits into from Dec 12, 2017
Merged

Update to Cordova iOS v4.5.4 #9448

merged 3 commits into from Dec 12, 2017

Conversation

skirunman
Copy link
Contributor

Update to Cordova iOS v4.5.4 to fix iPhone X splash screen issue.
Fixes #9447

Update to Cordova iOS v4.5.4 to fix iPhone X splash screen issue.
Fixes #9447
Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @skirunman - thanks very much - LGTM!

@abernix
Copy link
Contributor

abernix commented Dec 12, 2017

@skirunman Does this bump change need for the commented block of iPad modes here: https://github.com/skirunman/meteor/blob/4ae3b821b914657eec93df02a10bac33feb00944/tools/cordova/builder.js#L58-L62

@skirunman
Copy link
Contributor Author

skirunman commented Dec 12, 2017

@abernix My understanding is that Apple/Xcode, and therefore ios-cordova, does not, and likely will not, support iPad Pro launch screens as static image sizes. Instead, you need to use Xcode storyboard images.

Therefore, I actually think we should remove those commented out iPad Pro sizes. I can do it in this PR if you want or just do it yourself.

The current believe, per @skirunman (whose perspective on the matter I trust), is that these sizes won't be supported in this manner by Apple, but rather as storyboards.

Ref: #9448 (comment)
Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably get this into 1.6.1. Thanks, @skirunman.

@abernix abernix added this to the Release 1.6.1 milestone Dec 12, 2017
@abernix abernix merged commit ae3c05c into meteor:devel Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cordova iOS splash screen issue on iPhone X
3 participants