New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suppress logging of errors that have the `expected` flag #9515

Merged
merged 4 commits into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@jamesmillerburgess
Contributor

jamesmillerburgess commented Jan 4, 2018

Fixes #6912

This PR changes the log-suppressing property of errors in livedata_connection.js and livedata_server.js from expected to _expectedByTest in order to avoid inadvertently silencing errors in production.

jamesmillerburgess added some commits Nov 23, 2017

Change error suppressing property in livedata_connection.js
Fixes #6912
Switched the property from `expected` to `_expectedByTest`
@hwillson

Awesome @jamesmillerburgess - this looks great! If you have a chance, would you mind also:

  • Incrementing the patch version by 1 in the ddp-client, ddp-server, and mongo package.js files
  • Adding a small blurb about this change in the History.md

I'm still approving these changes though, so if you don't have time to address the above let us know, and we'll take care of it. Thanks!

@hwillson

This comment has been minimized.

Member

hwillson commented Jan 5, 2018

Thanks @jamesmillerburgess - LGTM!

(I'm not worried about the AppVeyor failure here - and your AppVeyor PR is a great idea, and should help.)

@benjamn benjamn merged commit ed98a07 into meteor:devel Jan 10, 2018

12 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abernix

This comment has been minimized.

Member

abernix commented Jan 10, 2018

Thanks very much for working on these issues, @jamesmillerburgess. Very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment