Do not suppress logging of errors that have the expected flag
#9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync fork
Fixes meteor#6912 Switched the property from `expected` to `_expectedByTest`
hwillson
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
Awesome @jamesmillerburgess - this looks great! If you have a chance, would you mind also:
- Incrementing the patch version by 1 in the
ddp-client,ddp-server, andmongopackage.jsfiles - Adding a small blurb about this change in the
History.md
I'm still approving these changes though, so if you don't have time to address the above let us know, and we'll take care of it. Thanks!
|
Thanks @jamesmillerburgess - LGTM! (I'm not worried about the AppVeyor failure here - and your AppVeyor PR is a great idea, and should help.) |
|
Thanks very much for working on these issues, @jamesmillerburgess. Very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6912
This PR changes the log-suppressing property of errors in
livedata_connection.jsandlivedata_server.jsfromexpectedto_expectedByTestin order to avoid inadvertently silencing errors in production.