Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a self-test skip option #9579
While doing some test work on another PR, I accidentally ran a
Meteor's CI infrastructure is configured to exclude certain
This commit adds a new
@benjamn I've pushed some tweaks to make this fall more in-line with the existing self-test summary. How about this:
So we don't show the name of the manually ignored tests, but we do list a manually ignored count (and mention that they were ignored by selftest.skip). This lines up with the approach used for the other skip tags, like "non-matching" - it doesn't show the names of the non-matching tests, just a count.
Let me know if this works - thanks!
Just a couple questions, but this looks great to me, even without addressing them. Feel free to merge this once you've reviewed!