Join GitHub today
Remove underscore from meteor-base #9596
This should shave down bundle sizes by 14.4 kb for many non-blaze projects.
The other core meteor packages have not depended on
Any meteor apps currently using
Adjustments to test apps:
There are only a few uses of
This is a problem, because the apps were relying on the dependency from
First, thank you so much for taking the time to work on great improvements like this.
AppVeyor won't build if there are any merge conflicts with the target branch as they build against a virtual GitHub branch which is meant to represent the "merge result", in an effort to try to provide early warning of what might eventually be a build a broken build. Currently, that merge conflict is just
Lastly, thanks again for taking the time to work on great improvements like this.
This is an awesome change @jamesmillerburgess, thanks!
The code changes look great, so I don't have any feedback there.
I am concerned that this change will inevitably upset people who don't have
underscore explicitly added to their project. What do people think - are we okay with just documenting this in the
History.md and letting people figure things out when they get application errors because
underscore is now missing?
I'll mark this a
request changes even though the code is okay, just until we hash out a plan of attack for making this change as painless as possible for existing users.
I agree with you that it isn't nice to introduce breaking changes without some kind of deprecation warning, although I can't think of an elegant way to do that for this particular situation:
Besides being difficult to detect for a deprecation warning, that's a pretty odd set of criteria, so I'm not even sure there are non-trivial apps out there that meet them. Hopefully that means the blast radius will be quite small if we go forward with the change.
I agree @jamesmillerburgess, I couldn't think of a better way of handling this either. I guess I'm just envisioning complaints rolling in from people who are used to just running
That being said, I like progress, so my vote goes towards exactly what you've done - mention this in the
Okay, enough rambling on my part - approved!
After talking about this in the issue triage meeting, we think decoupling
meteor-base is a good idea, but we're afraid that lots of apps will be broken when they update, so it's important to add
underscore back, separately from
meteor-base. The way to do this is to write an "upgrader" that modifies the
.meteor/packages file by adding
meteor-base is also used, assuming
underscore is not already there. This upgrader will run during
meteor update. See this file for lots of examples of other upgraders we've used over the years.
Thanks for pushing this forward!
I should be able to address the feedback for this and the other PRs either by tonight or tomorrow early morning. But I’ll let you know if I don’t have time and need some help. Thanks! Best regards, James…
________________________________ From: Hugh Willson <email@example.com> Sent: Thursday, February 8, 2018 5:17:43 PM To: meteor/meteor Cc: James Burgess; Mention Subject: Re: [meteor/meteor] Remove underscore from meteor-base (#9596) Just to add to #9596 (review)<#9596 (review)>, if you don't have time to look into writing the upgrader, let me know and I'll dig into it. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#9596 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APOnDPQH0Re09UpKK2Y53jK4JARqUKLVks5tSx4ngaJpZM4RxjEt>.