Skip to content

Conversation

@klaussner
Copy link
Contributor

@klaussner klaussner commented Apr 20, 2018

Since version 3.0.6 of the MongoDB driver, the internal client.s property is no longer necessary to create the database object. If MongoClient.prototype.db is called without arguments, it will use the database name from the connection URI (https://jira.mongodb.org/projects/NODE/issues/NODE-1258).

This reverts 567e620, see #9827 (comment).

@abernix I had to target release-1.7 instead of devel because the driver update from #9790 was merged into release-1.6.2 and isn't on devel yet. 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change back to 1.5.0-beta17.23, since 1.5.0 hasn't been released yet, and won't be released until Meteor 1.7 is released. Generally, when we bump the minor or major version of a package as part of a Meteor release, any changes to that package can be lumped into that one version.

The internal `client.s` property is no longer necessary to create the database object. If `MongoClient.prototype.db` is called without arguments, it will use the database name from the connection URI
(https://jira.mongodb.org/projects/NODE/issues/NODE-1258).
@benjamn benjamn merged commit 1555e3e into meteor:release-1.7 Apr 20, 2018
@benjamn benjamn added this to the Release 1.7 milestone Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants