Expose Meteor settings inside mobile-config #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
suggested changes
May 10, 2018
tools/cordova/builder.js
Outdated
| try { | ||
| settings = JSON.parse(files.readFile(options.settingsFile, 'utf8')); | ||
| } catch (e) { | ||
| throw new Error("METEOR_SETTINGS are not valid JSON."); |
There was a problem hiding this comment.
Let's check if e instanceof SyntaxError here… or better yet, use the optimisticReadJsonOrNull function to cache the parsed JSON.
|
@benjamn Should i updated the docs, also? |
|
Heads up: I'm going to merge this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR allows to access
Meteor.settingsinsidemobile-config.jsfile which leads to better developer experience for Cordova i.e. credentials sharing.there is a feature-request meteor/meteor-feature-requests#37
Example
What is still missing?
Documentation needs to be updated