Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating symlinks on Windows April 2018 Update #9887

Merged
merged 1 commit into from May 14, 2018

Conversation

@zodern
Copy link
Member

@zodern zodern commented May 13, 2018

symlinkWithOverwrite currently relies on Windows throwing an error when creating a file symlink with a source that is a folder, to know when the source is a folder and recreate the symlink as a junction. Windows 10 April 2018 Update no longer throws the error and instead creates the symlink despite it having the wrong type. This PR changes it to check if the source is a folder before creating the symlink.

Fixes #9863.

@apollo-cla
Copy link

@apollo-cla apollo-cla commented May 13, 2018

@zodern: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@benjamn benjamn merged commit 5f9fdda into meteor:devel May 14, 2018
18 checks passed
@lanmower
Copy link

@lanmower lanmower commented May 21, 2018

What's the status on this issue, I noticed that its half a month old already. Is meteor dropping windows support? My windows updated and now there is no way to run my project, which uses cordova.

@Markus-Mooqita
Copy link

@Markus-Mooqita Markus-Mooqita commented May 21, 2018

Hi we are facing a very similar problem that we are no longer able to work on our project.
Is there a workaround for this? Something that we can apply right now to continue working?

@benjamn
Copy link
Member

@benjamn benjamn commented May 21, 2018

@lanmower @Markus-Mooqita Have you tried the latest Meteor 1.7 release candidates, which include this fix?

@Markus-Mooqita
Copy link

@Markus-Mooqita Markus-Mooqita commented May 21, 2018

Hi @benjamn we are working on that at the moment. I will let you know if that solves the issue.
Is there an easy way to install the dev-build through meteors cli? Just found the answer: meteor update --release 1.7-rc.11

Is there a list of releases I only found this: https://docs.meteor.com/changelog.html
Which does not include the RC builds.

@meteorjsbrasil
Copy link

@meteorjsbrasil meteorjsbrasil commented May 22, 2018

Guys, same problem here, whats the progress on this?

@Markus-Mooqita
Copy link

@Markus-Mooqita Markus-Mooqita commented May 22, 2018

Hi all,

I updated yesterday to 1.7-rc.11 it worked but had some side effects in our project that needed fixing so take this solution with a grain of salt. You can update to a working version using this:

meteor update --release 1.7-rc.11

Be aware it can have unexpected side effects.

Cheers,
Markus

@meteorjsbrasil
Copy link

@meteorjsbrasil meteorjsbrasil commented May 22, 2018

I'm updating right now to see what happen. do you know what are the side effects ?

@Markus-Mooqita
Copy link

@Markus-Mooqita Markus-Mooqita commented May 22, 2018

Hi @meteorjsbrasil the side effects were mostly around our a little wired combination of tools, coffeescript 2.0, and the useracccounts plugin do not like each other. useracccounts requires coffeescript@1.0.4 and we needed to convert from import {component} "package" to require("package").component calls to fix another issue that appeared. These might all be very specific issues with our code base though.

@meteorjsbrasil
Copy link

@meteorjsbrasil meteorjsbrasil commented May 22, 2018

No problems at the moment and I could start the application and do an small test on it and it seams all is working. When you guys will merge this fix into meteor so we dont need to update to specific release?

@Markus-Mooqita
Copy link

@Markus-Mooqita Markus-Mooqita commented May 22, 2018

@meteorjsbrasil sorry I am not the right one to ask. I am just a user like you.

@andrewlorenz
Copy link

@andrewlorenz andrewlorenz commented May 22, 2018

I simply regressed the windows update, and everything meteor/node just sprung magically back to life - by meteor I mean the current 1.6 production release and not the 1.7 release candidates. The option to regress windows was rather hidden (I'd never had to use it before), but it was simple and painless. More importantly, it took me OUT of this painful dependency of waiting/hoping for MDG to provide a fix. Because even though 1.7 rc 11 (I think it was) solved the problem this issue identifies, it led me to encounter another different meteor related problem - one for which there appears to be no fix, and few hits on google. I need to keep my dev project going, and I've got enough of my own bugs! so I don't have time to investigate those for meteor. Regression back to the previous windows version seems the best bet - if its possible for you to do so.

@jestersoftware
Copy link

@jestersoftware jestersoftware commented May 24, 2018

@benjamn It would be so so great to get this fix into a 1.6 hotfix so we can just meteor update without going to 1.7 until it's ready. Thank you for consideration.

@NitroBAY
Copy link

@NitroBAY NitroBAY commented May 26, 2018

@jestersoftware Yes ! +10000 Simple fix needs in emergency to be merged in 1.6. I need to deploy my app I don't think I should rely on some alpha versions...
BTW set test on windows and especially do tests when people from Windows insider warn you that things have broken. Not the first time Windows support broke.

@benjamn
Copy link
Member

@benjamn benjamn commented May 26, 2018

If you don't want to update to the Meteor 1.7 release candidates yet, please try running

meteor update --release 1.6.1.2-rc.0

to install a preview of Meteor 1.6.1.2, which was created specifically to solve this problem.

@jestersoftware
Copy link

@jestersoftware jestersoftware commented Jun 1, 2018

Thank you @benjamn that worked. Really appreciate it!

@benjamn
Copy link
Member

@benjamn benjamn commented Jun 1, 2018

Oh, by the way, Meteor 1.6.1.2 is final now, so

meteor update --release 1.6.1.2

should work.

benjamn added a commit that referenced this issue Mar 9, 2019
Adding @zodern as a collaborator with write access (including
triage/review), based on contributions that demonstrate deep understanding
of the meteor/meteor codebase: #9887, #10399, #10452, #10453, #10454

Also updated other parts of CHANGELOG.md to reflect 2019 realities.
benjamn added a commit that referenced this issue Mar 13, 2019
Adding @zodern as a collaborator with write access (including
triage/review), based on contributions that demonstrate deep understanding
of the meteor/meteor codebase: #9887, #10399, #10452, #10453, #10454

Also updated other parts of CHANGELOG.md to reflect 2019 realities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

9 participants