New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.1.2 #9910

Merged
merged 5 commits into from May 26, 2018

Conversation

Projects
None yet
2 participants
@benjamn
Member

benjamn commented May 26, 2018

This is a very small release intended to fix #9863 by making #9887 available to Windows users without forcing them to update to Meteor 1.7 (yet). Thanks very much to @zodern for identifying a solution to this problem.

In short, after the Windows April 2018 Update, the Windows file system suddenly stopped reporting any error when fs.symlink failed, which caused Meteor to continue as if the symlink had been created, when in fact it had not. While I don't understand how this new behavior can be considered anything other than a bug, we don't have any control over the QA of Windows releases, so I suppose we just have to cope with their mistakes.

benjamn and others added some commits Mar 24, 2018

Call files.cp_r with { preserveSymlinks: true } in more places.
Now that symlinks can be used to enable selective compilation of
node_modules, it's important to preserve them.

@benjamn benjamn added this to the Release 1.6.1.2 milestone May 26, 2018

@benjamn benjamn self-assigned this May 26, 2018

@benjamn benjamn requested a review from abernix May 26, 2018

@benjamn benjamn changed the base branch from devel to master May 26, 2018

benjamn added some commits May 26, 2018

@benjamn benjamn merged commit 65fe55e into master May 26, 2018

12 of 14 checks passed

ci/circleci: Group 2 CircleCI is running your tests
Details
ci/circleci: Group 3 CircleCI is running your tests
Details
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Group 7 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment