Let any client request any static resource. #9965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
reviewed
Jun 7, 2018
| const staticFiles = staticFilesByArch[arch]; | ||
|
|
||
| // If staticFiles contains originalPath with the arch inferred above, | ||
| // use that information. | ||
| if (hasOwn.call(staticFiles, originalPath)) { | ||
| return staticFiles[originalPath]; | ||
| return info = staticFiles[originalPath]; |
There was a problem hiding this comment.
can you simplify this by using .find instead of .some?
There was a problem hiding this comment.
It would be a little weird because we started with an array of archs, but we want to end up with either staticFiles[originalPath] or staticFiles[path], neither of which is a an arch from the original array.
hwillson
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9953.
cc @glasser @morloy