New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let any client request any static resource. #9965

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
3 participants
@benjamn
Member

benjamn commented Jun 7, 2018

Fixes #9953.

cc @glasser @morloy

@benjamn benjamn requested review from glasser, hwillson and abernix Jun 7, 2018

@benjamn benjamn self-assigned this Jun 7, 2018

@benjamn benjamn added this to the Package Patches milestone Jun 7, 2018

const staticFiles = staticFilesByArch[arch];
// If staticFiles contains originalPath with the arch inferred above,
// use that information.
if (hasOwn.call(staticFiles, originalPath)) {
return staticFiles[originalPath];
return info = staticFiles[originalPath];

This comment has been minimized.

@glasser

glasser Jun 7, 2018

Member

can you simplify this by using .find instead of .some?

This comment has been minimized.

@benjamn

benjamn Jun 7, 2018

Member

It would be a little weird because we started with an array of archs, but we want to end up with either staticFiles[originalPath] or staticFiles[path], neither of which is a an arch from the original array.

@hwillson

Great idea and looks good! 👍

@benjamn benjamn merged commit 0a33617 into devel Jun 7, 2018

20 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Clean Up Your tests passed on CircleCI!
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 10 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment