Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version constraint on core typescirpt package #308

Merged

Conversation

CaptainN
Copy link
Collaborator

@CaptainN CaptainN commented Dec 9, 2020

We don't need to specify version constrains on core packages when using versionsFrom.

There is also nothing in this implementation that specifically requires the latest version of Meteor or the typescript package, so we should probably specify a range.

We don't need to specify version constrains on core packages (https://docs.meteor.com/api/packagejs.html#PackageAPI-versionsFrom)[when using `versionsFrom`.]

There is also nothing in this implementation that specifically requires the latest version of Meteor or the typescript package, so we should probably specify a range.
@filipenevola filipenevola merged commit f4f6ad4 into master Jan 20, 2021
1 check passed
@filipenevola filipenevola deleted the remove-version-constraint-on-core-typescirpt-package branch January 20, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants